chore(KFLUXVNGD-157): Add custom certificate support for coverity-oci-ta task #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ta task Add param to support the custom certificate support for coverity-check-oci-ta task to connect to internal registry. For this we have updated the use-trusted-artifact step, which download/upload the artifact from/to a registry. Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-157 Signed-off-by: Homaja Marisetty <[email protected]>
kdudka
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Note that coverity-availability-check-oci-ta/0.1 is now obsoleted by coverity-availability-check-oci-ta/0.2, which is a symlink to coverity-availability-check/0.2: https://github.com/konflux-ci/build-definitions/blob/e3d943064ac3f74fa462d54ba4020077d0091a11/task/coverity-availability-check-oci-ta/0.2/coverity-availability-check-oci-ta.yaml
| @@ -29,6 +29,15 @@ spec: | |||
| description: The Trusted Artifact URI pointing to the artifact with | |||
| the application source code. | |||
| type: string | |||
| - name: caTrustConfigMapKey | |||
There was a problem hiding this comment.
@hmariset Could you please check the CI failure? https://github.com/konflux-ci/build-definitions/actions/runs/13017347426/job/36309685062?pr=1867
I get the same diff when I run hack/generate-ta-tasks.sh locally:
--- a/task/coverity-availability-check-oci-ta/0.1/coverity-availability-check-oci-ta.yaml
+++ b/task/coverity-availability-check-oci-ta/0.1/coverity-availability-check-oci-ta.yaml
@@ -29,15 +29,6 @@ spec:
description: The Trusted Artifact URI pointing to the artifact with
the application source code.
type: string
- - name: caTrustConfigMapKey
- description: The name of the key in the ConfigMap that contains the
- CA bundle data.
- type: string
- default: ca-bundle.crt
- - name: caTrustConfigMapName
- description: The name of the ConfigMap to read CA bundle data from.
- type: string
- default: trusted-ca
results:
- name: STATUS
description: Tekton task simple status to be later checked
@@ -54,13 +45,6 @@ spec:
secretName: $(params.COV_LICENSE)
- name: workdir
emptyDir: {}
- - name: trusted-ca
- configMap:
- items:
- - key: $(params.caTrustConfigMapKey)
- path: ca-bundle.crt
- name: $(params.caTrustConfigMapName)
- optional: true
stepTemplate:
volumeMounts:
- mountPath: /var/workdir
|
Closing this PR since this task is deprecated and removed from docker-build-oci-ta pipeline recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add param to support the custom certificate support for coverity-check-oci-ta task to connect to internal registry. For this we have updated the use-trusted-artifact step, which download/upload the artifact from/to a registry.
Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-157