feat(): Migrate sealights tasks from integration catalog to build-definitions #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flacatus
force-pushed
the
sealights
branch
7 times, most recently
from
38833eb to
b683c35
Compare
|
/retest |
mmorhun
approved these changes
Jan 29, 2025
chmeliik
reviewed
Jan 29, 2025
| @@ -95,6 +95,10 @@ | |||
| /stepactions/eaas-get-supported-ephemeral-cluster-versions @amisstea @avi-biton @hmariset @omeramsc @yftacherzog | |||
| /task/eaas-provision-space @amisstea @avi-biton @hmariset @omeramsc @yftacherzog | |||
|
|
|||
| # renovate groupName=sealights | |||
| /task/sealights-go @ascerra @flacatus @psturc @dbaez | |||
| /task/sealights-python @ascerra @flacatus @psturc @dbaez | |||
There was a problem hiding this comment.
Invited you and @ascerra to https://github.com/orgs/konflux-ci/teams/build-definition-contributors.
Is dbaez the correct username? https://github.com/dbaez
There was a problem hiding this comment.
The names of tasks that work with trusted artifacts have -oci-ta in the name, consider renaming for consistency.
Is there no need to have regular, non -trusted-artifacts versions of these tasks?
| PACKAGES_EXCLUDED_ENUM="$(IFS=,; printf "%s," "$@" | sed 's/,$//')" | ||
|
|
||
| wget -qO- https://agents.sealights.co/slgoagent/latest/slgoagent-linux-amd64.tar.gz | tar -xzv -C /usr/local/bin | ||
| wget -qO- https://agents.sealights.co/slcli/latest/slcli-linux-amd64.tar.gz | tar -xzv -C /usr/local/bin |
There was a problem hiding this comment.
Downloading a binary at runtime doesn't seem very secure. Do you have plans to build a container image with the sealights binaries?
| EXCLUDE_ENUM="$(IFS=,; printf "%s," "$@" | sed 's/,$//')" | ||
|
|
||
| # Installs Sealights Python agent. | ||
| pip install sealights-python-agent |
There was a problem hiding this comment.
Same here, installing an unspecified version at runtime is not great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I open this Pull Request to migrate the current Sealights tasks that are living currently in tekton-integration-catalog. The reason of migration is that we cannot use the tasks from catalog due to EC violations during builds. For now this migration is temporary until Konflux support https://issues.redhat.com/browse/KONFLUX-4530.
@ascerra @Dannyb48 @psturc @arewm @lcarva @konflux-ci/build-maintainers FYI