Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the common prefix of ImageRepository names #182

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

chmeliik
Copy link
Contributor

In short: the common prefix of ImageRepository names is too long, which triggers https://issues.redhat.com/browse/SRVKP-6798

Drop the prefix.

In short: the common prefix of ImageRepository names is too long, which
triggers https://issues.redhat.com/browse/SRVKP-6798

Drop the prefix.

Signed-off-by: Adam Cmiel <[email protected]>
Copy link

🚀 Preview is available at https://pr-182--konflux-docs.netlify.app

Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ifireball , does this look good to you as well?

Copy link
Member

@ifireball ifireball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, lgtm. I probably need to fix that in my sample repo as well. The long names can also cause the Tekton variabele data store to explode

@arewm arewm merged commit 54b0875 into konflux-ci:main Nov 27, 2024
2 checks passed
@chmeliik chmeliik deleted the no-imagerepo-prefix branch November 27, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants