Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Configuring Applications and Components as Code with Kustomize #20

Merged
merged 1 commit into from
May 16, 2024

Conversation

gtrivedi88
Copy link
Contributor

Purpose: The purpose of this PR is to develop the releasing an application content. I have copied the AppStudio content directly. We have to review and update it.

Copy link

github-actions bot commented May 9, 2024

🚀 Preview is available at

@gtrivedi88 gtrivedi88 requested a review from arewm May 10, 2024 07:07
Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: Should Component and Application be capitalized throughout?

@arewm arewm requested a review from ifireball May 10, 2024 15:50
@arewm
Copy link
Member

arewm commented May 10, 2024

@ifireball , it feels like there is some overlap between this documentation and the project version controller. Would you mind reviewing this PR?

@ifireball
Copy link
Member

@ifireball , it feels like there is some overlap between this documentation and the project version controller. Would you mind reviewing this PR?

Indeed it does seem like at least the multi-version section here could be simplified by using the project version controller. Maybe others as well. @gtrivedi88 can you please have a look at the multi-version HOWTO and see if the information there helps you simplify this HOWTO?

Copy link

🚀 Preview is available at

@gtrivedi88
Copy link
Contributor Author

As per discussion in slack, added a note at the end: https://redhat-internal.slack.com/archives/C0715J0KEBS/p1715577674171459

Copy link

🚀 Preview is available at

@arewm arewm changed the title Added onfiguring Applications and Components as Code with Kustomize Added Configuring Applications and Components as Code with Kustomize May 14, 2024
@gtrivedi88
Copy link
Contributor Author

gtrivedi88 commented May 16, 2024

@arewm All comments resolved. Could you please approve this PR or let me know if you have any additional suggestions?

Copy link

🚀 Preview is available at

@gtrivedi88 gtrivedi88 merged commit 97e3fe3 into konflux-ci:main May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants