Improve secrets #225
Merged
Improve secrets #225
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Basti <[email protected]>
|
🚀 Preview is available at https://pr-225--konflux-docs.netlify.app |
arewm
reviewed
Feb 6, 2025
| @@ -1,4 +1,5 @@ | |||
| = Creating secrets for your builds | |||
| :toc: | |||
There was a problem hiding this comment.
There is already a page index on the right side. I am not sure we need a table of contents here.
| @@ -0,0 +1,5 @@ | |||
| == External secrets from external vaults | |||
There was a problem hiding this comment.
Suggested change
| == External secrets from external vaults | |
| == Secrets from external vaults |
Signed-off-by: Martin Basti <[email protected]>
MartinBasti
force-pushed
the
improve-secrets
branch
from
141867f to
dbd9642
Compare
|
🚀 Preview is available at https://pr-225--konflux-docs.netlify.app |
arewm
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.