Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefetching dependencies #24

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

missmesss
Copy link
Contributor

The text is being reviewed and will probably see a bit of changes.

@missmesss missmesss marked this pull request as draft May 13, 2024 20:59
Copy link

🚀 Preview is available at

@missmesss missmesss marked this pull request as ready for review May 28, 2024 06:53
@missmesss missmesss requested a review from arewm May 28, 2024 06:53
Copy link

🚀 Preview is available at

@missmesss missmesss changed the title Draft: Prefetching dependencies Prefetching dependencies May 28, 2024
Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hermetic and prefetch-dependencies comments are relevant in multiple places but I didn't replicate the comment.

Cachi2 also supports yarn and prefetching pip wheels. How complete do we want this documentation vs. just referring to https://github.com/containerbuildsystem/cachi2/blob/main/docs/usage.md ?

@missmesss
Copy link
Contributor Author

@arewm I've added the changes requested by you but I understand you won't see them before the vacation.

I plan to merge this PR because the changes are quite straightforward (like updating parameters names).

@missmesss
Copy link
Contributor Author

Cachi2 also supports yarn and prefetching pip wheels. How complete do we want this documentation vs. just referring to https://github.com/containerbuildsystem/cachi2/blob/main/docs/usage.md ?

Thank you for pointing this out.
Usually we aim at not repeating (copypasting) docs that already exist. However, in case of this guide it makes sense to extend it with a section about Yarn. I'll open an issue about it and discuss it with my team.

@missmesss
Copy link
Contributor Author

Applied all requested changes. Since they're quite straightforward, e.g. changing parameters names, re-review isn't strictly needed, I'm merging this PR.

@missmesss missmesss merged commit 504707d into konflux-ci:main Jun 10, 2024
2 checks passed
@missmesss missmesss deleted the prefetching-dependencies branch June 10, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants