-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefetching dependencies #24
Prefetching dependencies #24
Conversation
🚀 Preview is available at |
docs/modules/ROOT/pages/how-tos/configuring/prefetching-dependencies.adoc
Show resolved
Hide resolved
🚀 Preview is available at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hermetic and prefetch-dependencies comments are relevant in multiple places but I didn't replicate the comment.
Cachi2 also supports yarn and prefetching pip wheels. How complete do we want this documentation vs. just referring to https://github.com/containerbuildsystem/cachi2/blob/main/docs/usage.md ?
docs/modules/ROOT/pages/how-tos/configuring/prefetching-dependencies.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/how-tos/configuring/prefetching-dependencies.adoc
Show resolved
Hide resolved
docs/modules/ROOT/pages/how-tos/configuring/prefetching-dependencies.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/how-tos/configuring/prefetching-dependencies.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/how-tos/configuring/prefetching-dependencies.adoc
Outdated
Show resolved
Hide resolved
@arewm I've added the changes requested by you but I understand you won't see them before the vacation. I plan to merge this PR because the changes are quite straightforward (like updating parameters names). |
Thank you for pointing this out. |
Applied all requested changes. Since they're quite straightforward, e.g. changing parameters names, re-review isn't strictly needed, I'm merging this PR. |
The text is being reviewed and will probably see a bit of changes.