chore(KFLUXUI-268): revision data on snapshot page is now clickable& directs to commit detail page #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rects to commit detail page
janaki29
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 80.14% 80.12% -0.03%
==========================================
Files 570 578 +8
Lines 21536 21554 +18
Branches 5076 5083 +7
==========================================
+ Hits 17260 17270 +10
- Misses 4251 4259 +8
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| expect(revisionLink).toBeInTheDocument(); | ||
| expect(revisionLink).toHaveAttribute( | ||
| 'href', | ||
| `/workspaces//applications/${rowData?.application}/commit/test-revision`, |
There was a problem hiding this comment.
probably should not be double //.
There was a problem hiding this comment.
Will update, thanks.
StanislavJochman
previously approved these changes
Feb 5, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://issues.redhat.com/browse/KFLUXUI-268
Description
The Revision reference on a Snapshot detail page is clickable and take the user to that particular commit detail page.
Type of change
Screen shots / Gifs for design review
Snapshot Detail Page:
Commit Details Page: