fix(KONFLUX-1680): filter records on creationTimestamp #92
Conversation
| @@ -37,7 +37,7 @@ describe('EnvironmentProvisionErrorAlert', () => { | |||
| expect(screen.getByTestId(/env-provision-err-alert/)).toBeInTheDocument(); | |||
| expect(screen.getByText('app-sample-go-basic-enterprise-contract')).toBeInTheDocument(); | |||
| expect(screen.getByText(/Snapshot failed to deploy/)).toBeInTheDocument(); | |||
| expect(screen.getByText(/Sep 19, 2023/)).toBeInTheDocument(); | |||
| expect(screen.getByText(/19. 9. 2023/)).toBeInTheDocument(); | |||
There was a problem hiding this comment.
This test is not consistend. 19. 9. 2023 works locally but not in github. Github works with Sep 19, 2023
There was a problem hiding this comment.
@sahil143 any idea how to fix this?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 80.12% 80.15% +0.02%
==========================================
Files 578 578
Lines 21554 21558 +4
Branches 5348 5341 -7
==========================================
+ Hits 17270 17279 +9
+ Misses 4259 4254 -5
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Overall LGTM. The HAC code has |
|
LGTM |
src/components/PipelineRun/PipelineRunListView/PipelineRunsListView.tsx
Outdated
Show resolved
Hide resolved
| jest.mock('../../../hooks/useApplications', () => ({ | ||
| useApplication: jest.fn().mockReturnValue([{ metadata: { name: 'test' } }, true]), | ||
| })); | ||
|
|
||
| jest.mock('../../Workspace/useWorkspaceInfo', () => ({ |
There was a problem hiding this comment.
Please create a utility to mock useApplication hook,
Look at https://github.com/konflux-ci/konflux-ui/blob/main/src/utils/test-utils.tsx#L213 how to create mock hook utility
src/components/PipelineRun/PipelineRunListView/PipelineRunsListView.tsx
Outdated
Show resolved
Hide resolved
|
LGTM Local version is working as expected. Please pay attention in the comments above |
StanislavJochman
force-pushed
the
KONFLUX-1680
branch
from
35cc03d to
0011b31
Compare
|
Changes are working although I am see 8 errors in spec files while the application loads. |
Backport of KFLUXBUGS-1680