fix(KFLUXUI-260): It's unclear to users from representation in UI that components must be unique per workspace #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for component name
…ed while creating application
janaki29
changed the title
sahil143
requested changes
Jan 23, 2025
src/components/ImportForm/ComponentSection/ComponentSection.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 80.11% 80.14% +0.02%
==========================================
Files 570 570
Lines 21452 21542 +90
Branches 5050 5078 +28
==========================================
+ Hits 17187 17265 +78
- Misses 4241 4252 +11
- Partials 24 25 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sahil143
requested changes
Jan 30, 2025
Comment on lines
+40
to
+45
| <HelperText> | ||
| <HelperTextItem> | ||
| Must be unique within tenant namespace{' '} | ||
| <span className="component-section-helper-text-namespace-highlighted">{namespace}</span> | ||
| </HelperTextItem> | ||
| </HelperText> |
There was a problem hiding this comment.
use input field prop helperText to set the helper text,
Comment on lines
+1
to
+3
| .component-section-helper-text-namespace-highlighted{ | ||
| font-weight: 800; | ||
| } |
There was a problem hiding this comment.
missing new line
Suggested change
| .component-section-helper-text-namespace-highlighted{ | |
| font-weight: 800; | |
| } | |
| .component-section { | |
| &__component-name { | |
| &--helper-text { | |
| font-weight: var(--pf-v5-global--FontWeight--bold); | |
| } | |
| } | |
| } |
Comment on lines
+74
to
+81
| if ( | ||
| error?.json?.reason === 'AlreadyExists' && | ||
| error?.json?.details?.kind === 'components' | ||
| ) | ||
| formikHelpers.setStatus({ | ||
| submitError: `Component "${error.json?.details?.name}" already exists in this namespace. Edit the name to be unique and try again.`, | ||
| }); | ||
| else formikHelpers.setStatus({ submitError: error.message }); |
There was a problem hiding this comment.
This seems redundant, you added helper text indicating name should be unique in namespace. We should just show the error message returned by the api
StanislavJochman
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://issues.redhat.com/browse/KFLUXUI-260)
Description
Helper text is added for user conveying component names should be unique within tenant's namespace.
Helper Text:** Must be unique within tenant namespace **
When creating application, if component name is duplicate then error message is updated to following message:
"Component already exists in this namespace. Edit the name to be unique and try again."
Unique default component name suggested after adding a URL while creating an application.
If same component name exists within namespace, then suffix "-[Ramndom Number]" is added.
Example: Component "sample-component" already exists within namespace, so suggested default component added is
"sample-component-50". Screenshot is also attached.
Type of change
Screen shots / Gifs for design review
3.Unique Default Component name is suggested