feat(KFLUXUI-36): updated wordings in customizepipelines component fo… #96
Conversation
…r install gitHub application
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 80.12% 80.14% +0.02%
==========================================
Files 578 578
Lines 21554 21537 -17
Branches 5348 5336 -12
==========================================
- Hits 17270 17261 -9
+ Misses 4259 4250 -9
- Partials 25 26 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/test |
| @@ -394,14 +396,11 @@ const CustomizePipeline: React.FC<React.PropsWithChildren<Props>> = ({ | |||
| {singleComponent ? 'Edit build pipeline plan' : 'Manage build pipelines'} | |||
There was a problem hiding this comment.
Remove 'Edit build pipeline plan', pluralize 'Manage build pipeline' if there is more than one component
There was a problem hiding this comment.
@sahil143 Can you please suggest if we need to remove 'Edit build pipeline plan'?
This is the old code which was never changed by me
Updated the pluralize 'Manage build pipeline'
There was a problem hiding this comment.
yes, Remove Edit build pipeline
There was a problem hiding this comment.
Removed "Edit build pipeline plan".
| const gitlabURL = | ||
| 'https://konflux-ci.dev/docs/how-tos/configuring/creating-secrets/#creating-source-control-secrets'; |
There was a problem hiding this comment.
You can use the link in component, no need to create a variable.
There was a problem hiding this comment.
Also in some ticket we changed gitlab and github naming to git.
There was a problem hiding this comment.
Updated the changes.
…lt pipeline button
| @@ -228,7 +175,7 @@ const Row: React.FC< | |||
| workspace, | |||
There was a problem hiding this comment.
should not here be namespace not workspace?
There was a problem hiding this comment.
This is present from the beginning. Please let me know if the change required.
There was a problem hiding this comment.
It gets changed in another PR so it should be fine.
Fixes
https://issues.redhat.com/browse/KFLUXUI-36
Description
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Browser conformance: