Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KFLUXUI-302): remove the join the waitlist flow from UI #99

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

StanislavJochman
Copy link
Contributor

Backport of KFLUXUI-302

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.32%. Comparing base (1d178fc) to head (b30b244).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Overview/IntroBanner.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   80.11%   80.32%   +0.21%     
==========================================
  Files         577      574       -3     
  Lines       21494    21358     -136     
  Branches     5327     5032     -295     
==========================================
- Hits        17219    17156      -63     
+ Misses       4251     4178      -73     
  Partials       24       24              
Flag Coverage Δ
unittests 80.32% <0.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JoaoPedroPP
JoaoPedroPP previously approved these changes Jan 29, 2025
Copy link
Contributor

@JoaoPedroPP JoaoPedroPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Join waitlist button was removed from the UI and its components deleted from the project.

Copy link
Contributor

@JoaoPedroPP JoaoPedroPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message to provide support is always on the screen and maybe we can improve style

src/components/Overview/IntroBanner.tsx Outdated Show resolved Hide resolved
src/components/Overview/IntroBanner.tsx Outdated Show resolved Hide resolved
JoaoPedroPP
JoaoPedroPP previously approved these changes Feb 11, 2025
Copy link
Contributor

@JoaoPedroPP JoaoPedroPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The UI is working and displaying the View applications only if there are applications.
The codecov/patch check can be ignored since it refers to deleted files

@JoaoPedroPP JoaoPedroPP force-pushed the KFLUXUI-302 branch 3 times, most recently from baa6680 to b30b244 Compare February 11, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants