-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(KFLUXUI-302): remove the join the waitlist flow from UI #99
base: main
Are you sure you want to change the base?
Conversation
src/components/SnapshotDetails/__tests__/EnvironmentProvisionErrorAlert.spec.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 80.11% 80.32% +0.21%
==========================================
Files 577 574 -3
Lines 21494 21358 -136
Branches 5327 5032 -295
==========================================
- Hits 17219 17156 -63
+ Misses 4251 4178 -73
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Join waitlist button was removed from the UI and its components deleted from the project.
src/components/SnapshotDetails/__tests__/EnvironmentProvisionErrorAlert.spec.tsx
Outdated
Show resolved
Hide resolved
99b834f
to
62bc3fe
Compare
62bc3fe
to
b10b916
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Message to provide support is always on the screen and maybe we can improve style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The UI is working and displaying the View applications
only if there are applications.
The codecov/patch check can be ignored since it refers to deleted files
baa6680
to
b30b244
Compare
Backport of KFLUXUI-302