-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RHTAPREL-714): add Tekton utilities #311
Conversation
fd6ff42
to
9212665
Compare
9212665
to
667c944
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be merged with e2e-tests changes and tenant config changes. It also has more things to change since you rebased
667c944
to
90ce90d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but not marking approval to make sure this doesn't get accidentally merged
90ce90d
to
9cc22e6
Compare
9cc22e6
to
e7b11b9
Compare
a7684b2
to
43cad07
Compare
/retest |
2 similar comments
/retest |
/retest |
3d678cc
to
cbd4d78
Compare
/retest |
cbd4d78
to
ffafdc0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
- Coverage 84.61% 83.78% -0.83%
==========================================
Files 29 30 +1
Lines 1800 1955 +155
==========================================
+ Hits 1523 1638 +115
- Misses 210 245 +35
- Partials 67 72 +5 ☔ View full report in Codecov by Sentry. |
The utilities added in this commit come from the shared-utils repository. In addition, the RPA already references the new Pipeline struct. Signed-off-by: David Moreno García <[email protected]>
ffafdc0
to
6368064
Compare
|
The utilities added in this commit come from the shared-utils repository. In addition, the RPA already references the new Pipeline struct.
Signed-off-by: David Moreno García [email protected]
Depends on #310