Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHTAPREL-714): add Tekton utilities #311

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

davidmogar
Copy link
Collaborator

The utilities added in this commit come from the shared-utils repository. In addition, the RPA already references the new Pipeline struct.

Signed-off-by: David Moreno García [email protected]

Depends on #310

mmalina
mmalina previously approved these changes Nov 30, 2023
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be merged with e2e-tests changes and tenant config changes. It also has more things to change since you rebased

tekton/utils/suite_test.go Outdated Show resolved Hide resolved
tekton/utils/pipeline.go Outdated Show resolved Hide resolved
tekton/utils/suite_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not marking approval to make sure this doesn't get accidentally merged

johnbieren
johnbieren previously approved these changes Jan 15, 2024
@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2024
@openshift-ci openshift-ci bot removed the lgtm label Jan 15, 2024
@davidmogar davidmogar force-pushed the rhtaprel714 branch 2 times, most recently from a7684b2 to 43cad07 Compare January 15, 2024 15:20
@davidmogar
Copy link
Collaborator Author

/retest

2 similar comments
@davidmogar
Copy link
Collaborator Author

/retest

@davidmogar
Copy link
Collaborator Author

/retest

@davidmogar davidmogar force-pushed the rhtaprel714 branch 5 times, most recently from 3d678cc to cbd4d78 Compare January 18, 2024 11:53
@davidmogar
Copy link
Collaborator Author

/retest

go.sum Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (034200c) 84.61% compared to head (6368064) 83.78%.
Report is 1 commits behind head on main.

Files Patch % Lines
tekton/utils/zz_generated.deepcopy.go 0.00% 25 Missing ⚠️
tekton/utils/pipeline_run_builder.go 90.00% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   84.61%   83.78%   -0.83%     
==========================================
  Files          29       30       +1     
  Lines        1800     1955     +155     
==========================================
+ Hits         1523     1638     +115     
- Misses        210      245      +35     
- Partials       67       72       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The utilities added in this commit come from the shared-utils
repository. In addition, the RPA already references the new
Pipeline struct.

Signed-off-by: David Moreno García <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

@openshift-ci openshift-ci bot added the lgtm label Jan 22, 2024
@davidmogar davidmogar merged commit 0eb0a45 into konflux-ci:main Jan 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants