Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHTAPREL-278): add match info to releasePlans and RPAs #315

Closed
wants to merge 3 commits into from

Conversation

jinqi7
Copy link
Contributor

@jinqi7 jinqi7 commented Dec 4, 2023

This commit adds a ReleasePlanAdmission controller and modifies the ReleasePlan controller. The controllers perform similar actions - the update their respective resource's Status to say whether or not it is matched to its paired resource.

@jinqi7 jinqi7 requested review from a team, theflockers, ralphbean, davidmogar, mmalina, scoheb, johnbieren and Troy876 and removed request for a team December 4, 2023 03:45
This commit adds a ReleasePlanAdmission controller and modifies the
ReleasePlan controller. The controllers perform similar actions - the
update their respective resource's Status to say whether or not it is
matched to its paired resource.

Signed-off-by: Johnny Bieren <[email protected]>
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jinqi7 jinqi7 marked this pull request as draft December 4, 2023 04:48
@jinqi7
Copy link
Contributor Author

jinqi7 commented Dec 4, 2023

/retest

Copy link

openshift-ci bot commented Dec 4, 2023

@jinqi7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/release-service-e2e ad17b41 link true /test release-service-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johnbieren
Copy link
Collaborator

johnbieren commented Dec 7, 2023

Is this supposed to be reviewed or are you just using it to match with e2e or something? It looks like it may be a copy of mine

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jinqi7 jinqi7 closed this Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants