feat(RHTAPREL-764): allow RPs to specify RPAs #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbieren
requested review from
a team,
theflockers,
ralphbean,
davidmogar,
mmalina,
scoheb,
gbenhaim and
jinqi7
and removed request for
a team
|
logic-wise lgtm. I'll let others approve. |
johnbieren
force-pushed
the
rhtaprel_764
branch
from
749be56 to
9b4a8e4
Compare
|
/test release-service-e2e |
This commit changes the logic for fetching a ReleasePlanAdmission for a given ReleasePlan. If the ReleasePlan contains a label for the ReleasePlanAdmission to use, that ReleasePlanAdmission is searched for directly. This allows operations to continue even if multiple ReleasePlanAdmissions exist in a single managed namespace. Signed-off-by: Johnny Bieren <[email protected]>
johnbieren
force-pushed
the
rhtaprel_764
branch
from
9b4a8e4 to
4ecdf5b
Compare
|
davidmogar
approved these changes
Dec 12, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 83.93% 83.98% +0.04%
==========================================
Files 29 29
Lines 1737 1742 +5
==========================================
+ Hits 1458 1463 +5
Misses 211 211
Partials 68 68 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the logic for fetching a ReleasePlanAdmission for a given ReleasePlan. If the ReleasePlan contains a label for the ReleasePlanAdmission to use, that ReleasePlanAdmission is searched for directly. This allows operations to continue even if multiple ReleasePlanAdmissions exist in a single managed namespace.