-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(RELEASE-1277): release controller crashes #655
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
==========================================
- Coverage 79.23% 78.17% -1.07%
==========================================
Files 28 28
Lines 2283 2318 +35
==========================================
+ Hits 1809 1812 +3
- Misses 389 421 +32
Partials 85 85 ☔ View full report in Codecov by Sentry. |
759da84
to
ff392e4
Compare
Tests will be added in a separate PR that refactors main: https://github.com/konflux-ci/release-service/pull/660/files |
/retest |
0ced0b3
to
8079023
Compare
/ok-to-test |
/retest |
/retest |
1 similar comment
/retest |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see E2E passed, so we are good with this now? Can you squash the commits?
this PR tries to fix/decrease the daily crashes of the release controller by filtering objects to cache and increasing the lease renew time. Signed-off-by: Leandro Mendes <[email protected]>
afc9a2a
to
1b03d25
Compare
I will merge. But lets put it only on stage for now, so I can look for some numbers. |
this PR tries to fix/decrease the daily crashes of the release controller by filtering objects to cache and increasing the lease renew time.