Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RELEASE-1277): release controller crashes #655

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

theflockers
Copy link
Collaborator

this PR tries to fix/decrease the daily crashes of the release controller by filtering objects to cache and increasing the lease renew time.

Copy link

openshift-ci bot commented Jan 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@theflockers
Copy link
Collaborator Author

this PR replaces: #545 and #617

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 7.69231% with 36 lines in your changes missing coverage. Please review.

Project coverage is 78.17%. Comparing base (f1cc9bd) to head (1b03d25).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
main.go 0.00% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   79.23%   78.17%   -1.07%     
==========================================
  Files          28       28              
  Lines        2283     2318      +35     
==========================================
+ Hits         1809     1812       +3     
- Misses        389      421      +32     
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theflockers theflockers force-pushed the release-1277 branch 6 times, most recently from 759da84 to ff392e4 Compare January 28, 2025 10:30
@theflockers
Copy link
Collaborator Author

Tests will be added in a separate PR that refactors main: https://github.com/konflux-ci/release-service/pull/660/files

@theflockers theflockers marked this pull request as ready for review January 28, 2025 10:47
@theflockers theflockers requested a review from a team as a code owner January 28, 2025 10:47
metadata/labels.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
johnbieren
johnbieren previously approved these changes Jan 28, 2025
main.go Show resolved Hide resolved
@theflockers
Copy link
Collaborator Author

/retest

@theflockers theflockers force-pushed the release-1277 branch 2 times, most recently from 0ced0b3 to 8079023 Compare January 29, 2025 10:27
@theflockers
Copy link
Collaborator Author

/ok-to-test

@theflockers
Copy link
Collaborator Author

/retest

main.go Outdated Show resolved Hide resolved
@theflockers
Copy link
Collaborator Author

/retest

1 similar comment
@theflockers
Copy link
Collaborator Author

/retest

@theflockers
Copy link
Collaborator Author

/ok-to-test

@theflockers theflockers marked this pull request as ready for review January 30, 2025 12:18
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see E2E passed, so we are good with this now? Can you squash the commits?

this PR tries to fix/decrease the daily crashes of the release
controller by filtering objects to cache and increasing the
lease renew time.

Signed-off-by: Leandro Mendes <[email protected]>
@theflockers
Copy link
Collaborator Author

I see E2E passed, so we are good with this now? Can you squash the commits?

I will merge. But lets put it only on stage for now, so I can look for some numbers.

@openshift-ci openshift-ci bot added the lgtm label Jan 31, 2025
@theflockers theflockers merged commit 6f93a81 into konflux-ci:main Jan 31, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants