test: fix owner reference test in releasePlan adapter #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envtest doesn't delete owned resources, so the test checking that the releasePlan was removed when the application was deleted in the releasePlan adapter was misleading. It only was passing because it was missing the namespace. This commit removes the misleading test and improves the one checking the ownerReference. Signed-off-by: Johnny Bieren <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
==========================================
- Coverage 79.21% 79.12% -0.09%
==========================================
Files 28 28
Lines 2247 2247
==========================================
- Hits 1780 1778 -2
- Misses 384 385 +1
- Partials 83 84 +1 ☔ View full report in Codecov by Sentry. |
happybhati
approved these changes
Jan 24, 2025
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envtest doesn't delete owned resources, so the test checking that the releasePlan was removed when the application was deleted in the releasePlan adapter was misleading. It only was passing because it was missing the namespace. This commit removes the misleading test and improves the one checking the ownerReference.