Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 pass label selector via initialize() #436

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 pass label selector via initialize() #436

wants to merge 1 commit into from

Conversation

pranavgaikwad
Copy link
Contributor

@pranavgaikwad pranavgaikwad commented Mar 7, 2025 •
edited
Loading

Depends on konveyor/kai#732

@pranavgaikwad pranavgaikwad requested a review from a team as a code owner March 7, 2025 17:47
@pranavgaikwad pranavgaikwad marked this pull request as draft March 7, 2025 17:56
sjd78
sjd78 reviewed Mar 7, 2025
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a corresponding PR on kai that you can reference?

If this PR is merged before it is supported on the kai binary, the init and therefore server startup will probably fail.

@sjd78
Copy link
Member

sjd78 commented Mar 7, 2025

Is there a corresponding PR on kai that you can reference?

If this PR is merged before it is supported on the kai binary, the init and therefore server startup will probably fail.

You added it before I finished typing up my comment! 😄

@pranavgaikwad pranavgaikwad marked this pull request as ready for review March 11, 2025 13:53
@pranavgaikwad pranavgaikwad requested a review from sjd78 March 11, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 Awaiting requested review from sjd78

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranavgaikwad @sjd78