Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase max line length in style enforcement #970

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

rgwozdz
Copy link
Member

@rgwozdz rgwozdz commented Apr 12, 2024

I guess 80 chars is often considered the standard but it really forces a lot of linebreaks that make reading a chore. Bumping to 100 chars.

@rgwozdz rgwozdz self-assigned this Apr 12, 2024
Copy link

changeset-bot bot commented Apr 12, 2024

⚠️ No Changeset found

Latest commit: 0cab9df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Coverage Report (change vs master)

File Path Statements Branches Functions Lines
packages/core/src/index.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/core/src/data-provider/extend-controller.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/core/src/data-provider/extend-model.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/core/src/data-provider/index.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/core/src/data-provider/provider-route.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/core/src/data-provider/helpers/compose-route-path.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/layer-metadata.js 100 green vs 100 green 50 red vs 50 red 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/layers-metadata.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/metadata-defaults.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/queryRelatedRecords.js 14.81 red vs 14.81 red 0 red vs 0 red 0 red vs 0 red 15.38 red vs 14.81 red
packages/featureserver/src/rest-info-route-handler.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/route.js 85.71 yellow vs 85.71 yellow 76.47 orange vs 76.47 orange 100 green vs 100 green 85.71 yellow vs 85.71 yellow
packages/featureserver/src/server-info-route-handler.js 98.14 yellowGreen vs 98.14 yellowGreen 100 green vs 100 green 100 green vs 100 green 98.14 yellowGreen vs 98.14 yellowGreen
packages/featureserver/src/generate-renderer/color-ramp.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/generate-renderer/create-symbol.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/generate-renderer/index.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/generate-renderer/validate-classification-definition.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/helpers/data-type-utils.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/helpers/feature-layer-metadata.js 93.87 yellowGreen vs 93.87 yellowGreen 73.68 orange vs 73.68 orange 100 green vs 100 green 93.87 yellowGreen vs 93.87 yellowGreen
packages/featureserver/src/helpers/get-geometry-type-from-geojson.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/helpers/is-geojson-table.js 90.9 yellowGreen vs 90.9 yellowGreen 58.33 red vs 58.33 red 100 green vs 100 green 90 yellow vs 90 yellow
packages/featureserver/src/helpers/normalize-extent.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/helpers/normalize-input-data.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/helpers/normalize-request-params.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/helpers/normalize-spatial-reference.js 97.82 yellowGreen vs 97.82 yellowGreen 91.17 yellowGreen vs 91.17 yellowGreen 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/helpers/server-metadata.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/helpers/table-layer-metadata.js 98.7 yellowGreen vs 98.7 yellowGreen 89.79 yellow vs 89.79 yellow 100 green vs 100 green 98.68 yellowGreen vs 98.7 yellowGreen
packages/featureserver/src/helpers/validate-inputs.js 100 green vs 100 green 88.88 yellow vs 88.88 yellow 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/helpers/fields/esri-type-utils.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/helpers/fields/field-classes.js 98.03 yellowGreen vs 98.03 yellowGreen 85 yellow vs 85 yellow 100 green vs 100 green 98.03 yellowGreen vs 98.03 yellowGreen
packages/featureserver/src/helpers/fields/fields.js 97.14 yellowGreen vs 97.14 yellowGreen 91.66 yellowGreen vs 91.66 yellowGreen 100 green vs 100 green 96.96 yellowGreen vs 96.96 yellowGreen
packages/featureserver/src/helpers/fields/statistics-fields.js 97.29 yellowGreen vs 97.29 yellowGreen 80 orange vs 80 orange 100 green vs 100 green 97.14 yellowGreen vs 97.22 yellowGreen
packages/featureserver/src/query/filter-and-transform.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/query/index.js 100 green vs 100 green 94.28 yellowGreen vs 94.28 yellowGreen 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/query/log-provider-data-warnings.js 97.22 yellowGreen vs 97.22 yellowGreen 97.87 yellowGreen vs 97.87 yellowGreen 100 green vs 100 green 97.22 yellowGreen vs 97.22 yellowGreen
packages/featureserver/src/query/render-count-and-extent.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/query/render-features.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/query/render-precalculated-statistics.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/query/render-statistics.js 100 green vs 100 green 50 red vs 50 red 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/query/validate-query-request-parameters.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/response-handlers/general-response-handler.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/response-handlers/query-response-handler.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/response-handlers/helpers/send-callback.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/response-handlers/helpers/send-pretty-json.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/response-handlers/helpers/send-pbf/get-geometry-transform.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/response-handlers/helpers/send-pbf/index.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/response-handlers/helpers/send-pbf/transform-features-for-pbf.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/response-handlers/helpers/send-pbf/transform-to-pbf-attributes.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/response-handlers/helpers/send-pbf/transform-to-pbf-geometry.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/logger/src/index.js 37.5 red vs 37.5 red 31.81 red vs 31.81 red 40 red vs 40 red 40 red vs 38.7 red
packages/output-geoservices/src/index.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/index.js 0 red vs 0 red 100 green vs 100 green 100 green vs 100 green 0 red vs 0 red
packages/winnow/src/calculate-class-breaks/filter-and-validate-classification-features.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/calculate-class-breaks/index.js 90.32 yellowGreen vs 90.32 yellowGreen 80 orange vs 80 orange 100 green vs 100 green 92.85 yellowGreen vs 90.32 yellowGreen
packages/winnow/src/calculate-class-breaks/normalize-classification-values.js 100 green vs 100 green 94.44 yellowGreen vs 94.44 yellowGreen 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/calculate-class-breaks/transform-class-breaks-to-ranges.js 96.66 yellowGreen vs 96.66 yellowGreen 92.3 yellowGreen vs 92.3 yellowGreen 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/filter-and-transform/filter-and-transform.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/filter-and-transform/prepare-filter-and-transform.js 94.73 yellowGreen vs 94.73 yellowGreen 94.44 yellowGreen vs 94.44 yellowGreen 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/filter-and-transform/filters/envelope-intersects.js 95 yellowGreen vs 95 yellowGreen 88.23 yellow vs 88.23 yellow 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/filter-and-transform/filters/hashed-objectid-comparator.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/filter-and-transform/helpers/hash-function.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/filter-and-transform/transforms/project.js 92.3 yellowGreen vs 92.3 yellowGreen 87.5 yellow vs 87.5 yellow 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/filter-and-transform/transforms/reduce-precision.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/filter-and-transform/transforms/to-esri-attributes.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/helpers/project-coordinates.js 90.9 yellowGreen vs 90.9 yellowGreen 88.88 yellow vs 88.88 yellow 100 green vs 100 green 90 yellow vs 90 yellow
packages/winnow/src/helpers/transform-coordinates.js 100 green vs 100 green 66.66 red vs 66.66 red 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/normalize-query-options/aggregates.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/normalize-query-options/classification.js 91.66 yellowGreen vs 91.66 yellowGreen 80.95 yellow vs 80.95 yellow 100 green vs 100 green 91.3 yellowGreen vs 91.66 yellowGreen
packages/winnow/src/normalize-query-options/collection.js 93.75 yellowGreen vs 93.75 yellowGreen 81.81 yellow vs 81.81 yellow 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/normalize-query-options/date-fields.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/normalize-query-options/geometry-filter-spatial-reference.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/normalize-query-options/geometry-filter.js 96.96 yellowGreen vs 96.96 yellowGreen 84.61 yellow vs 84.61 yellow 100 green vs 100 green 96.87 yellowGreen vs 96.87 yellowGreen
packages/winnow/src/normalize-query-options/id-field.js 100 green vs 100 green 95.23 yellowGreen vs 95.23 yellowGreen 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/normalize-query-options/limit.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/normalize-query-options/offset.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/normalize-query-options/output-data-spatial-reference.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/normalize-query-options/source-data-spatial-reference.js 90.9 yellowGreen vs 90.9 yellowGreen 80 orange vs 80 orange 100 green vs 100 green 90 yellow vs 90 yellow
packages/winnow/src/normalize-query-options/spatial-reference.js 98.07 yellowGreen vs 98.07 yellowGreen 94.11 yellowGreen vs 94.11 yellowGreen 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/normalize-query-options/where.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/query/classification-query.js 89.47 yellow vs 89.47 yellow 80 orange vs 80 orange 100 green vs 100 green 88.88 yellow vs 89.47 yellow
packages/winnow/src/query/normalize-query-input.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/query/package-features.js 84.61 yellow vs 84.61 yellow 66.66 red vs 66.66 red 100 green vs 100 green 84.61 yellow vs 84.61 yellow
packages/winnow/src/query/prepare-query.js 100 green vs 100 green 50 red vs 50 red 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/query/query.js 100 green vs 100 green 80 orange vs 80 orange 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/query/standard-query.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/query/unique-value-query.js 100 green vs 100 green 80 orange vs 80 orange 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/sql-query-builder/create-sql-params.js 100 green vs 100 green 81.25 yellow vs 81.25 yellow 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/sql-query-builder/create-sql-string.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/sql-query-builder/order-by.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/sql-query-builder/select/fields-select-fragment.js 100 green vs 100 green 92.85 yellowGreen vs 92.85 yellowGreen 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/sql-query-builder/select/geometry-select-fragment.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/sql-query-builder/select/index.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/sql-query-builder/where-builder/index.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green
packages/winnow/src/sql-query-builder/where-builder/to-json-where.js 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green 100 green vs 100 green

@rgwozdz rgwozdz merged commit e215a22 into master Apr 12, 2024
7 checks passed
@rgwozdz rgwozdz deleted the rf/ln-len branch April 12, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant