Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Fix iOS Bug where wrong image is shown. #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

To Fix iOS Bug where wrong image is shown. #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
012e3c5
To make file name unique and avoid name mismatch, adding intervalStri…
necixy Nov 12, 2018
a44890d
Update README.md
necixy Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Forked Note:
Original library was great in every manner. In iOS, there was a small bug that cropping new image returned old image path which showed incorrect image. To make file name unique and avoid name mismatch, adding intervalString as an extra layer in the file name for iOS and it solved problem (at least for me). Feel free to use forked version this if you're facing the same bug in the original library.

# Cordova Image Cropper
Cordova plugin for image cropping with custom aspect ratio.

Expand Down
5 changes: 4 additions & 1 deletion src/ios/KImageCropper.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,10 @@ - (NSString*)tempFilePath:(NSString*)extension
// generate unique file name
int i = 1;
do {
filePath = [NSString stringWithFormat:@"%@/%@%03d.%@", docsPath, CDV_PHOTO_PREFIX, i++, extension];
// To make file name unique and avoid name mismatch, adding intervalString as an extra layer in the file name.
NSTimeInterval today = [[NSDate date] timeIntervalSince1970];
NSString *intervalString = [NSString stringWithFormat:@"%f", today];
filePath = [NSString stringWithFormat:@"%@/%@%03d_%@.%@", docsPath, CDV_PHOTO_PREFIX, i++, intervalString , extension];
} while ([fileMgr fileExistsAtPath:filePath]);

return filePath;
Expand Down