test: fix flaky TestIntegration_MRDScaleUpConnections#3
Conversation
The test was flaky because queueing all 100 requests at once could flood the event loop's cmds channel, causing the select block to repeatedly pick the Add commands over the connection add channel. This prevented the manager from tracking scaled-up streams before the test completed. This change batches the requests, giving the event loop natural breaks to process stream creation deterministically without using non-deterministic sleeps. Co-authored-by: krishnamd-jkp <230955344+krishnamd-jkp@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
The test was flaky because queueing all 100 requests at once could flood the event loop's cmds channel, causing the select block to repeatedly pick the Add commands over the connection add channel. This prevented the manager from tracking scaled-up streams before the test completed. This change batches the requests, giving the event loop natural breaks to process stream creation deterministically without using non-deterministic sleeps. It also reduces maxConnections from 3 to 2 for improved reliability. Co-authored-by: krishnamd-jkp <230955344+krishnamd-jkp@users.noreply.github.com>
1 participant
Fixes flaky TestIntegration_MRDScaleUpConnections
PR created automatically by Jules for task 2242440705306567336 started by @krishnamd-jkp