Skip to content

Potential fix for code scanning alert no. 3: Clear-text logging of sensitive information #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

krishnprakash
Copy link
Owner

Potential fix for https://github.com/krishnprakash/cloudflare-docs/security/code-scanning/3

To fix the problem, we need to ensure that sensitive information such as client_id and client_secret is not logged in clear text. Instead, we can log a message indicating that a service token was created without including the sensitive details. This way, we maintain the functionality of informing the user about the creation of the service token without exposing sensitive data.

We will modify the log statement on line 149 to remove the sensitive information. Specifically, we will change the log message to indicate that a service token was created without including the client_id and client_secret.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…nsitive information

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@krishnprakash krishnprakash marked this pull request as ready for review March 19, 2025 11:13
@krishnprakash krishnprakash merged commit 76093d6 into production Mar 19, 2025
10 checks passed
@krishnprakash krishnprakash deleted the alert-autofix-3 branch March 19, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant