Potential fix for code scanning alert no. 1: Clear-text logging of sensitive information #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Deploying cloudflare-docs with
|
| Latest commit: |
7d8f901
|
| Status: | 🚫 Build failed. |
|
Howdy and thanks for contributing to our repo. We review new, external PRs within 2 weeks. If it's been longer than then without any movement, tag the PR Assignees in a comment. |
krishnprakash
added a commit
that referenced
this pull request
Mar 6, 2025
…39) * Potential fix for code scanning alert no. 1: Clear-text logging of sensitive information (#35) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Potential fix for code scanning alert no. 3: Clear-text logging of sensitive information (#36) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * [Docs Site] Bump @typescript-eslint/parser from 8.25.0 to 8.26.0 (#28) Dependabot couldn't find the original pull request head commit, a75b142. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Docs Site] Bump typescript-eslint from 8.25.0 to 8.26.0 (#29) Dependabot couldn't find the original pull request head commit, 2b80971. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Docs Site] Bump prettier from 3.5.2 to 3.5.3 (#30) Dependabot couldn't find the original pull request head commit, 4e69d6c. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Docs Site] Bump wrangler from 3.109.3 to 3.111.0 (#32) Dependabot couldn't find the original pull request head commit, 4202e58. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump the npm_and_yarn group across 4 directories with 2 updates (#33) Bumps the npm_and_yarn group with 2 updates in the /.github/actions/assign-issue directory: [esbuild](https://github.com/evanw/esbuild) and [cross-spawn](https://github.com/moxystudio/node-cross-spawn). Bumps the npm_and_yarn group with 2 updates in the /.github/actions/assign-pr directory: [esbuild](https://github.com/evanw/esbuild) and [cross-spawn](https://github.com/moxystudio/node-cross-spawn). Bumps the npm_and_yarn group with 1 update in the /.github/actions/label-products directory: [esbuild](https://github.com/evanw/esbuild). Bumps the npm_and_yarn group with 1 update in the /.github/actions/label-size directory: [esbuild](https://github.com/evanw/esbuild). Updates `esbuild` from 0.14.39 to 0.25.0 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2022.md) - [Commits](evanw/esbuild@v0.14.39...v0.25.0) Updates `cross-spawn` from 7.0.3 to 7.0.6 - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) Updates `esbuild` from 0.14.39 to 0.25.0 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2022.md) - [Commits](evanw/esbuild@v0.14.39...v0.25.0) Updates `cross-spawn` from 7.0.3 to 7.0.6 - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) Updates `esbuild` from 0.14.39 to 0.25.0 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2022.md) - [Commits](evanw/esbuild@v0.14.39...v0.25.0) Updates `esbuild` from 0.14.39 to 0.25.0 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2022.md) - [Commits](evanw/esbuild@v0.14.39...v0.25.0) --- updated-dependencies: - dependency-name: esbuild dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: cross-spawn dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: esbuild dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: cross-spawn dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: esbuild dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: esbuild dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Docs Site] Bump vitest from 2.1.6 to 2.1.9 in the npm_and_yarn group (#34) Bumps the npm_and_yarn group with 1 update: [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `vitest` from 2.1.6 to 2.1.9 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v2.1.9/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Docs Site] Bump vitest in the npm_and_yarn group across 1 directory (#37) Bumps the npm_and_yarn group with 1 update in the / directory: [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `vitest` from 2.1.9 to 3.0.7 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v3.0.7/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/net (#38) Bumps the go_modules group with 1 update in the /tools directory: [golang.org/x/net](https://github.com/golang/net). Updates `golang.org/x/net` from 0.23.0 to 0.33.0 - [Commits](golang/net@v0.23.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect dependency-group: go_modules ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Docs Site] Bump @cloudflare/vitest-pool-workers from 0.7.4 to 0.7.5 Bumps [@cloudflare/vitest-pool-workers](https://github.com/cloudflare/workers-sdk/tree/HEAD/packages/vitest-pool-workers) from 0.7.4 to 0.7.5. - [Release notes](https://github.com/cloudflare/workers-sdk/releases) - [Changelog](https://github.com/cloudflare/workers-sdk/blob/main/packages/vitest-pool-workers/CHANGELOG.md) - [Commits](https://github.com/cloudflare/workers-sdk/commits/@cloudflare/[email protected]/packages/vitest-pool-workers) --- updated-dependencies: - dependency-name: "@cloudflare/vitest-pool-workers" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Phileco <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
krishnprakash
added a commit
that referenced
this pull request
Mar 6, 2025
* Potential fix for code scanning alert no. 1: Clear-text logging of sensitive information (#35) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Potential fix for code scanning alert no. 3: Clear-text logging of sensitive information (#36) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * [Docs Site] Bump @typescript-eslint/parser from 8.25.0 to 8.26.0 (#28) Dependabot couldn't find the original pull request head commit, a75b142. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Docs Site] Bump typescript-eslint from 8.25.0 to 8.26.0 (#29) Dependabot couldn't find the original pull request head commit, 2b80971. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Docs Site] Bump prettier from 3.5.2 to 3.5.3 (#30) Dependabot couldn't find the original pull request head commit, 4e69d6c. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Docs Site] Bump wrangler from 3.109.3 to 3.111.0 (#32) Dependabot couldn't find the original pull request head commit, 4202e58. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump the npm_and_yarn group across 4 directories with 2 updates (#33) Bumps the npm_and_yarn group with 2 updates in the /.github/actions/assign-issue directory: [esbuild](https://github.com/evanw/esbuild) and [cross-spawn](https://github.com/moxystudio/node-cross-spawn). Bumps the npm_and_yarn group with 2 updates in the /.github/actions/assign-pr directory: [esbuild](https://github.com/evanw/esbuild) and [cross-spawn](https://github.com/moxystudio/node-cross-spawn). Bumps the npm_and_yarn group with 1 update in the /.github/actions/label-products directory: [esbuild](https://github.com/evanw/esbuild). Bumps the npm_and_yarn group with 1 update in the /.github/actions/label-size directory: [esbuild](https://github.com/evanw/esbuild). Updates `esbuild` from 0.14.39 to 0.25.0 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2022.md) - [Commits](evanw/esbuild@v0.14.39...v0.25.0) Updates `cross-spawn` from 7.0.3 to 7.0.6 - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) Updates `esbuild` from 0.14.39 to 0.25.0 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2022.md) - [Commits](evanw/esbuild@v0.14.39...v0.25.0) Updates `cross-spawn` from 7.0.3 to 7.0.6 - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) Updates `esbuild` from 0.14.39 to 0.25.0 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2022.md) - [Commits](evanw/esbuild@v0.14.39...v0.25.0) Updates `esbuild` from 0.14.39 to 0.25.0 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2022.md) - [Commits](evanw/esbuild@v0.14.39...v0.25.0) --- updated-dependencies: - dependency-name: esbuild dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: cross-spawn dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: esbuild dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: cross-spawn dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: esbuild dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: esbuild dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Docs Site] Bump vitest from 2.1.6 to 2.1.9 in the npm_and_yarn group (#34) Bumps the npm_and_yarn group with 1 update: [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `vitest` from 2.1.6 to 2.1.9 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v2.1.9/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Docs Site] Bump vitest in the npm_and_yarn group across 1 directory (#37) Bumps the npm_and_yarn group with 1 update in the / directory: [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `vitest` from 2.1.9 to 3.0.7 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v3.0.7/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/net (#38) Bumps the go_modules group with 1 update in the /tools directory: [golang.org/x/net](https://github.com/golang/net). Updates `golang.org/x/net` from 0.23.0 to 0.33.0 - [Commits](golang/net@v0.23.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect dependency-group: go_modules ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Docs Site] Bump typescript from 5.7.3 to 5.8.2 Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.7.3 to 5.8.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.7.3...v5.8.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Phileco <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/krishnprakash/cloudflare-docs/security/code-scanning/1
To fix the problem, we need to ensure that sensitive information such as
client_secretis not logged in clear text. Instead of logging the entire command, we can log a sanitized version of it that excludes the sensitive information. This way, we can still have useful logging for debugging purposes without exposing sensitive data.We will modify the logging statement on line 72 to exclude the
client_secretfrom the logged command. We will also add a helper function to sanitize the command before logging it.Suggested fixes powered by Copilot Autofix. Review carefully before merging.