Skip to content

Potential fix for code scanning alert no. 3: Clear-text logging of sensitive information #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

krishnprakash
Copy link
Owner

Potential fix for https://github.com/krishnprakash/cloudflare-docs/security/code-scanning/3

To fix the problem, we need to ensure that sensitive information such as client_secret is not logged in clear text. Instead, we can log a message indicating that a service token was created without including the sensitive details. This way, we maintain the functionality of informing the user about the creation of the service token without exposing sensitive information.

We will modify the logging statement on line 149 to exclude the client_secret. We will also ensure that any other sensitive information is not logged in clear text.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…nsitive information

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@krishnprakash krishnprakash marked this pull request as ready for review March 15, 2025 06:04
@krishnprakash krishnprakash merged commit 40fcb61 into production Mar 15, 2025
8 of 9 checks passed
@krishnprakash krishnprakash deleted the alert-autofix-3 branch March 15, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant