Merge pull request #346 from krishnprakash/alert-autofix-14

krishnprakash · web-flow · commit 11f9b1963662 · 2025-03-11T15:11:53.000+05:30
Potential fix for code scanning alert no. 14: Local scope variable shadows member
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/TypeMention.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/TypeMention.cs
@@ -117,13 +117,6 @@ protected override void Populate(TextWriter trapFile)
                     return;
             }
         }
-
-        private void Emit(TextWriter trapFile, Microsoft.CodeAnalysis.Location location, IEntity parent, Type type)
-        {
-            trapFile.type_mention(this, type.TypeRef, parent);
-            trapFile.type_mention_location(this, Context.CreateLocation(location));
-        }
-
         public static TypeMention Create(Context cx, TypeSyntax syntax, IEntity parent, Type type, Microsoft.CodeAnalysis.Location? loc = null)
         {
             var ret = new TypeMention(cx, syntax, parent, type, loc);

Original file line number	Diff line number	Diff line change
`@@ -117,13 +117,6 @@ protected override void Populate(TextWriter trapFile)`
`117`	`117`	`return;`
`118`	`118`	`}`
`119`	`119`	`}`
`120`		`-`
`121`		`- private void Emit(TextWriter trapFile, Microsoft.CodeAnalysis.Location location, IEntity parent, Type type)`
`122`		`- {`
`123`		`- trapFile.type_mention(this, type.TypeRef, parent);`
`124`		`- trapFile.type_mention_location(this, Context.CreateLocation(location));`
`125`		`- }`
`126`		`-`
`127`	`120`	`public static TypeMention Create(Context cx, TypeSyntax syntax, IEntity parent, Type type, Microsoft.CodeAnalysis.Location? loc = null)`
`128`	`121`	`{`
`129`	`122`	`var ret = new TypeMention(cx, syntax, parent, type, loc);`