Merge pull request #344 from krishnprakash/alert-autofix-12

krishnprakash · web-flow · commit 658011c2f8e1 · 2025-03-11T15:06:01.000+05:30
Potential fix for code scanning alert no. 12: Local scope variable shadows member
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/TypeMention.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/TypeMention.cs
@@ -118,10 +118,10 @@ protected override void Populate(TextWriter trapFile)
             }
         }
 
-        private void Emit(TextWriter trapFile, Microsoft.CodeAnalysis.Location loc, IEntity parent, Type type)
+        private void Emit(TextWriter trapFile, Microsoft.CodeAnalysis.Location location, IEntity parent, Type type)
         {
             trapFile.type_mention(this, type.TypeRef, parent);
-            trapFile.type_mention_location(this, Context.CreateLocation(loc));
+            trapFile.type_mention_location(this, Context.CreateLocation(location));
         }
 
         public static TypeMention Create(Context cx, TypeSyntax syntax, IEntity parent, Type type, Microsoft.CodeAnalysis.Location? loc = null)

Original file line number	Diff line number	Diff line change
`@@ -118,10 +118,10 @@ protected override void Populate(TextWriter trapFile)`
`118`	`118`	`}`
`119`	`119`	`}`
`120`	`120`
`121`		`- private void Emit(TextWriter trapFile, Microsoft.CodeAnalysis.Location loc, IEntity parent, Type type)`
	`121`	`+ private void Emit(TextWriter trapFile, Microsoft.CodeAnalysis.Location location, IEntity parent, Type type)`
`122`	`122`	`{`
`123`	`123`	`trapFile.type_mention(this, type.TypeRef, parent);`
`124`		`- trapFile.type_mention_location(this, Context.CreateLocation(loc));`
	`124`	`+ trapFile.type_mention_location(this, Context.CreateLocation(location));`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`public static TypeMention Create(Context cx, TypeSyntax syntax, IEntity parent, Type type, Microsoft.CodeAnalysis.Location? loc = null)`