Support re-encoding of indefinite length types.#113
Open
mesudip wants to merge 1 commit into
Open
Conversation
mesudip
force-pushed
the
feat/indefinite-re-encoding
branch
from
660244f to
3051cf6
Compare
Mudloop
reviewed
Jul 4, 2025
| if(prop == 'constructor'){ | ||
| return target[prop] | ||
| } | ||
| return (combinedString[prop]).bind(combinedString); |
There was a problem hiding this comment.
Might want to use Reflect.get instead of manually binding, it might handle some edge cases.
But instead of using a proxy, why not just :
Object.assign(combinedString, { _cbor_indef: strings });That will probably be a little more performant
EDIT : didn't notice this was old-ish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Its important for my use-case that re-encoding some portion of decoded data creates the same binary.
What
When decoding indefinite length array, text, binary or map,