Support concat without buffer#70
Open
jimmywarting wants to merge 1 commit into
Open
Conversation
kriszyp
reviewed
Feb 8, 2023
Owner
There was a problem hiding this comment.
This looks great... but this concat isn't actually reachable because we currently throw before getting to that line for major types 2 and 3:
Line 294 in b3b3ed0
I think with this improved concat in place, we could now enable this (remove this throw), right?
Also would be nice to get in a test for this.
Anyway, thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.