Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SADR-3128 another one safeframe implementation #3

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

SADR-3128 another one safeframe implementation #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a9c267a
SADR-3128 another one safeframe implementation
Aug 17, 2022
c9bb73a
SADR-3128 import host
Aug 17, 2022
de10d11
SADR-2128 fix linter issue
Aug 17, 2022
3a5235a
SADR-3128 very important change in html
Aug 17, 2022
3e5c105
SADR-3128 avoid removing amp-ad element
Aug 18, 2022
d29d84e
SADR-3128 use prod frame
Aug 18, 2022
3cbcd7e
SADR-3128 fix for safeframe communication
Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions examples/amp-ad/smartadserver.amp.safeframe.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<!doctype html>
<html ⚡ lang="en">
<head>
<meta charset="utf-8">
<title>Smartadserver Examples</title>
<link rel="canonical" href="http://nonblocking.io/">
<meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1">
<style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript>
<script async custom-element="amp-ad" src="https://cdn.ampproject.org/v0/amp-ad-0.1.js"></script>
<script async src="https://cdn.ampproject.org/v0.js"></script>
<!-- <script src="https://demo.smartadserver.com/shared/Smart/dodziomek/sf/js/base.js"></script>
<script src="https://demo.smartadserver.com/shared/Smart/dodziomek/sf/js/host.js"></script> -->
</head>
<body>

Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.

<!-- Format : top_rwd 300x250 -->
<amp-ad width="300" height="250" type="smartadserver" data-domain="https://www4.smartadserver.com"
data-site="65518" data-page="502594" data-format="28727" data-target="ric=11058653" data-use-safeframe="true">
</amp-ad>

Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.
Lorem ipsum dolor sit amet consectetur, adipisicing elit. Explicabo dolores laborum obcaecati nostrum vitae consectetur illo eligendi et. Fuga repellat necessitatibus consequatur harum asperiores esse deleniti expedita possimus nulla nihil.

</body>
</html>
53 changes: 49 additions & 4 deletions extensions/amp-ad-network-smartadserver-impl/0.1/amp-ad-network-smartadserver-impl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,17 @@

import {buildUrl} from '#ads/google/a4a/shared/url-builder';

import {tryResolve} from '#core/data-structures/promise';
import {getPageLayoutBoxBlocking} from '#core/dom/layout/page-layout-box';
import {tryParseJson} from '#core/types/object/json';
import {utf8Decode} from '#core/types/string/bytes';

import {Services} from '#service';

import {dev} from '#utils/log';

import './base_host';

import {getOrCreateAdCid} from '../../../src/ad-cid';
import {getConsentPolicyInfo} from '../../../src/consent';
import {AmpA4A, XORIGIN_MODE} from '../../amp-a4a/0.1/amp-a4a';
Expand All @@ -49,6 +53,15 @@ export class AmpAdNetworkSmartadserverImpl extends AmpA4A {
*/
constructor(element) {
super(element);

this.useSafeframe = false;
if (
'useSafeframe' in this.element.dataset &&
this.element.dataset['useSafeframe'] === 'true'
) {
this.useSafeframe = true;
}

this.addListener();
}

Expand Down Expand Up @@ -107,11 +120,43 @@ export class AmpAdNetworkSmartadserverImpl extends AmpA4A {
});
}

/** @override */
renderViaNameAttrOfXOriginIframe_(creativeBody) {
tryResolve(() => utf8Decode(creativeBody)).then((creative) => {
const newChildEl = document.createElement('div');
newChildEl.id = `ampAdId-${this.sentinel}`;
this.element.appendChild(newChildEl);

new window.$sf.host.Config({
renderFile:
'https://demo.smartadserver.com/shared/Smart/dodziomek/sf/frame.html',
});
new window.$sf.host.PosConfig({
id: newChildEl.id,
w: this.getCreativeSize().width,
h: this.getCreativeSize().height,
dest: newChildEl.id,
});
window.$sf.host.render(
new window.$sf.host.Position(newChildEl.id, creative)
);
});

return super.renderViaNameAttrOfXOriginIframe_(creativeBody);
}

/** @override */
iframeRenderHelper_() {}

/** @override */
getNonAmpCreativeRenderingMethod(headerValue) {
return Services.platformFor(this.win).isIos()
? XORIGIN_MODE.IFRAME_GET
: super.getNonAmpCreativeRenderingMethod(headerValue);
if (this.useSafeframe) {
return XORIGIN_MODE.SAFEFRAME;
} else {
return Services.platformFor(this.win).isIos()
? XORIGIN_MODE.IFRAME_GET
: super.getNonAmpCreativeRenderingMethod(headerValue);
}
}

/** @override */
Expand Down Expand Up @@ -168,7 +213,7 @@ export class AmpAdNetworkSmartadserverImpl extends AmpA4A {

/** @override */
isXhrAllowed() {
return false;
return this.useSafeframe ? true : false;
}

/**
Expand Down
Loading