feat: Make container build engine configurable #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Allow to run make goals provinding the desired Container Enginer builder tool, e.g. `ENGINE=podman make build` Signed-off-by: Spolti <[email protected]>
rafvasq
changed the title
ckadner
approved these changes
May 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ckadner do you think it can be merged? |
|
Thanks. |
openshift-merge-bot bot
referenced
this pull request
in opendatahub-io/modelmesh-runtime-adapter
Oct 11, 2024
chore: Allow to run make goals provinding the desired Container Enginer builder tool, e.g. `ENGINE=podman make build` Signed-off-by: Spolti <[email protected]>
openshift-merge-bot bot
referenced
this pull request
in opendatahub-io/modelmesh-runtime-adapter
Nov 20, 2024
* feat: Make container build engine configurable (#87) chore: Allow to run make goals provinding the desired Container Enginer builder tool, e.g. `ENGINE=podman make build` Signed-off-by: Spolti <[email protected]> * chore: Update dependencies chore: Update dependencies Signed-off-by: Spolti <[email protected]> --------- Signed-off-by: Spolti <[email protected]>
openshift-merge-bot bot
referenced
this pull request
in opendatahub-io/modelmesh-runtime-adapter
Jan 23, 2025
* feat: Make container build engine configurable (#87) chore: Allow to run make goals provinding the desired Container Enginer builder tool, e.g. `ENGINE=podman make build` Signed-off-by: Spolti <[email protected]> * chore: Update dependencies chore: Update dependencies Signed-off-by: Spolti <[email protected]> * chore: Update dependencies (kserve#97) chore: Fixes the following CVEs: CVE-2023-45288 - Non-linear parsing of case-insensitive content in golang.org/x/net/html CVE-2024-45337 - Misuse of ServerConfig.PublicKeyCallback may cause authorization bypass in golang.org/x/crypto #### Motivation #### Modifications #### Result Signed-off-by: Spolti <[email protected]> --------- Signed-off-by: Spolti <[email protected]>
openshift-merge-bot bot
referenced
this pull request
in opendatahub-io/modelmesh-runtime-adapter
Feb 20, 2025
* feat: Make container build engine configurable (#87) chore: Allow to run make goals provinding the desired Container Enginer builder tool, e.g. `ENGINE=podman make build` Signed-off-by: Spolti <[email protected]> * chore: Update dependencies chore: Update dependencies Signed-off-by: Spolti <[email protected]> * chore: Update dependencies (kserve#97) chore: Fixes the following CVEs: CVE-2023-45288 - Non-linear parsing of case-insensitive content in golang.org/x/net/html CVE-2024-45337 - Misuse of ServerConfig.PublicKeyCallback may cause authorization bypass in golang.org/x/crypto #### Motivation #### Modifications #### Result Signed-off-by: Spolti <[email protected]> --------- Signed-off-by: Spolti <[email protected]> Signed-off-by: Brett Thompson <[email protected]> Co-authored-by: Filippe Spolti <[email protected]>
openshift-merge-bot bot
referenced
this pull request
in opendatahub-io/modelmesh-runtime-adapter
Feb 26, 2025
* feat: Make container build engine configurable (#87) chore: Allow to run make goals provinding the desired Container Enginer builder tool, e.g. `ENGINE=podman make build` Signed-off-by: Spolti <[email protected]> * chore: Update dependencies chore: Update dependencies Signed-off-by: Spolti <[email protected]> * chore: Update dependencies (kserve#97) chore: Fixes the following CVEs: CVE-2023-45288 - Non-linear parsing of case-insensitive content in golang.org/x/net/html CVE-2024-45337 - Misuse of ServerConfig.PublicKeyCallback may cause authorization bypass in golang.org/x/crypto #### Motivation #### Modifications #### Result Signed-off-by: Spolti <[email protected]> * Upgrade python to 3.11 (kserve#98) chore: Update python to 3.11 in preparation of UBI9 upgrade. #### Motivation #### Modifications #### Result Signed-off-by: Spolti <[email protected]> --------- Signed-off-by: Spolti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Allow to run make goals provinding the desired Container Enginer builder tool,
e.g.
ENGINE=podman make buildMotivation
Modifications
Result