Skip to content

Commit

Permalink
remove verbose error comment
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Kadner <[email protected]>
  • Loading branch information
ckadner committed Jan 9, 2024
1 parent 349274e commit 947e0e6
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions scripts/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -338,28 +338,6 @@ if [[ $enable_self_signed_ca == "true" ]]; then
rm default/kustomization.yaml.bak
fi

# watch out when newTag has no non-numeric characters, and gets interpreted as an int, rather than srting
# sed -i.bak 's/newTag:.*$/newTag: '"$GIT_COMMIT_SHORT"'/' config/manager/kustomization.yaml
# ++ sed -i.bak 's/newTag:.*$/newTag: 7284872/' config/manager/kustomization.yaml
# Error: accumulating resources from '../manager':
# '/config/manager' must resolve to a file':
# couldn't make target for path '/config/manager':
# invalid Kustomization:
# json: cannot unmarshal number into Go struct field
# Image.images.newTag of type string
# error: no objects passed to apply
# CLI check:
# git log -1 --format=%h --abbrev=7
# 7284872
# This happened 7 times as of 2023/12/02:
# git log --format=%h --abbrev=7 | grep -E "^[0-9]+$"
# 7284872
# 4808804
# 4746079
# 0281170
# 1631706
# 5293579
# 4207065
info "kustomize build default"
kustomize build default | kubectl apply -f -

Expand Down

0 comments on commit 947e0e6

Please sign in to comment.