Skip to content

Conversation

@KairusZhang
Copy link

KERNEL_VERSION ?= 6.12.8 delete the 6.12.8, it will affect the version of Linux-qemu download

KERNEL_VERSION ?= 6.12.8 delete the 6.12.8, it will affect the version of Linux-qemu download

Signed-off-by: Kairus Zhang <[email protected]>
@KairusZhang KairusZhang requested review from a team as code owners October 23, 2025 14:59
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @KairusZhang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where a specific kernel version was hardcoded within the Makefile, which was reported to affect the download process for Linux-qemu. By removing the explicit version number, the system can now dynamically determine the appropriate kernel version or allow it to be set externally, thereby preventing potential conflicts and enhancing the flexibility of the build process.

Highlights

  • KERNEL_VERSION Default: The default assignment for the KERNEL_VERSION variable in the Makefile has been removed. Previously, it was hardcoded to 6.12.8.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly removes the hardcoded default for KERNEL_VERSION in the Makefile to allow for more flexibility with different hypervisors. My review includes one comment pointing out that the help documentation for this variable is now misleading and should be updated to prevent confusion.

GUESTOS_IMAGE ?= centos
WASM_RUNTIME ?= wasmedge
KERNEL_VERSION ?= 6.12.8
KERNEL_VERSION ?=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing the hardcoded default for KERNEL_VERSION is a good change for flexibility across different hypervisors. However, this makes the help text on line 153 potentially misleading. It states the default is 6.12.8, which is now only true for the default cloud_hypervisor (due to a fallback in its build script) but not necessarily for others like qemu. To avoid confusion for future developers, please update the help text to clarify that the default depends on the hypervisor.

@KairusZhang KairusZhang changed the title repaire KERNEL_VERSION Eliminate the impact of the KERNEL_VERSION parameter Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant