-
Notifications
You must be signed in to change notification settings - Fork 103
Eliminate the impact of the KERNEL_VERSION parameter #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
KERNEL_VERSION ?= 6.12.8 delete the 6.12.8, it will affect the version of Linux-qemu download Signed-off-by: Kairus Zhang <[email protected]>
Summary of ChangesHello @KairusZhang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where a specific kernel version was hardcoded within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request correctly removes the hardcoded default for KERNEL_VERSION in the Makefile to allow for more flexibility with different hypervisors. My review includes one comment pointing out that the help documentation for this variable is now misleading and should be updated to prevent confusion.
| GUESTOS_IMAGE ?= centos | ||
| WASM_RUNTIME ?= wasmedge | ||
| KERNEL_VERSION ?= 6.12.8 | ||
| KERNEL_VERSION ?= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the hardcoded default for KERNEL_VERSION is a good change for flexibility across different hypervisors. However, this makes the help text on line 153 potentially misleading. It states the default is 6.12.8, which is now only true for the default cloud_hypervisor (due to a fallback in its build script) but not necessarily for others like qemu. To avoid confusion for future developers, please update the help text to clarify that the default depends on the hypervisor.
KERNEL_VERSION ?= 6.12.8 delete the 6.12.8, it will affect the version of Linux-qemu download