Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip commit #106

Merged
merged 2 commits into from
Dec 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions hkube_python_wrapper/communication/zmq/streaming/ZMQListener.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@

context = zmq.Context()
POLL_MS = 1000
MAX_SKIPS = 150
MAX_POLLS = 5


class ZMQListener(object):
def __init__(self, remoteAddress, onMessage, encoding, consumerType):
self._encoding = encoding
Expand All @@ -18,6 +20,8 @@ def __init__(self, remoteAddress, onMessage, encoding, consumerType):
self._pollTimeoutCount = 0
self._remoteAddress = remoteAddress
self._worker = self._worker_socket(remoteAddress)
self._numberOfNoMsg = 0
self._numberOfTimesSkipped = 0

def _worker_socket(self, remoteAddress):
"""Helper function that returns a new configured socket
Expand All @@ -43,24 +47,26 @@ def fetch(self):
if (self._active is False):
time.sleep(0.2)
return

if (self._pollTimeoutCount == MAX_POLLS):
log.warning('ZMQListener poll timeout reached')
self._pollTimeoutCount = 0
self._worker.close()
self._worker = self._worker_socket(self._remoteAddress)

if (self._pollTimeoutCount > 0):
skip = self._numberOfTimesSkipped < MAX_SKIPS and self._numberOfNoMsg > 0
if not skip:
self._numberOfTimesSkipped = 0
if (self._pollTimeoutCount == MAX_POLLS):
log.warning('ZMQListener poll timeout reached')
self._pollTimeoutCount = 0
self._worker.close()
self._worker = self._worker_socket(self._remoteAddress)
if (self._pollTimeoutCount > 0):
self._readMessage()
return
self._send(signals.PPP_READY)
self._readMessage()
return

self._send(signals.PPP_READY)
self._readMessage()

else:
time.sleep(0.01)
self._numberOfTimesSkipped += 1
except Exception as e:
log.error('ZMQListener.fetch {e}', e=str(e))
finally:
if(self._active is False):
if (self._active is False):
self._working = False

def _readMessage(self, timeout=POLL_MS):
Expand All @@ -75,7 +81,9 @@ def _readMessage(self, timeout=POLL_MS):
hasMsg = True
msgResult = self._handleAMessage(frames)
self._send(signals.PPP_DONE, msgResult)
self._numberOfNoMsg = 0
else:
self._numberOfNoMsg += 1
time.sleep(0.005)
else:
self._pollTimeoutCount += 1
Expand Down
2 changes: 1 addition & 1 deletion tests/test_streaming.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def statsInvoked(args):
streamingManagerC.startMessageListening()

streamingManagerA.sendMessage('msg from A')
time.sleep(1)
time.sleep(2)
assert resultsAtB['data'] == 'msg from A'
assert resultsAtB['origin'] == 'A'
assert resultsAtC['data'] == 'msg from B'
Expand Down