Skip to content

Conversation

@shaneutt
Copy link
Member

@shaneutt shaneutt commented Oct 31, 2025

@clux, for your considerations this is an interim solution for #1821. Only after I finished this did I see there was another PR. This approach is very focused, matching the "empty" extra obj, and removing it when found. This also adds a regression test for Optional<Enum> behavior.

needs #1842

This is a temporary workaround for an issue in kube 2.x:

kube-rs#1821

Signed-off-by: Shane Utt <[email protected]>
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.7%. Comparing base (b14f3d7) to head (2316532).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1841     +/-   ##
=======================================
+ Coverage   74.6%   74.7%   +0.1%     
=======================================
  Files         84      84             
  Lines       7910    7931     +21     
=======================================
+ Hits        5900    5923     +23     
+ Misses      2010    2008      -2     
Files with missing lines Coverage Δ
kube-core/src/schema.rs 96.1% <100.0%> (+1.0%) ⬆️
kube-derive/tests/crd_schema_test.rs 100.0% <100.0%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good patch to fix the issue. I recall trying once to use some of the schemars options like AddNullable transform as recommended in https://github.com/GREsau/schemars/blob/master/CHANGELOG.md#changed-3 but it didn’t have an effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants