Karmor support for windows and removal of cilium #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review @daemon1024 @nyrahul |
Aryan-sharma11
requested changes
Jan 16, 2025
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]>
Aryan-sharma11
force-pushed
the
windows
branch
from
b0b257f to
d66f740
Compare
Signed-off-by: Aryan-sharma11 <[email protected]>
Aryan-sharma11
force-pushed
the
windows
branch
from
16a26ec to
43358a5
Compare
|
Thanks for the commits @Aryan-sharma11, can you please tell me what is causing these security check failures? |
Signed-off-by: Aryan-sharma11 <[email protected]>
Aryan-sharma11
force-pushed
the
windows
branch
from
b2a1ee2 to
f8b32b0
Compare
|
Tested on windows working as expected |
|
LGTM |
Aryan-sharma11
approved these changes
Jan 16, 2025
daemon1024
approved these changes
Jan 16, 2025
Manik2708
added a commit
to Manik2708/kubearmor-client
that referenced
this pull request
Jan 17, 2025
* windows support Signed-off-by: Manik2708 <[email protected]> * cilium removed Signed-off-by: Manik2708 <[email protected]> * some changes reverted Signed-off-by: Manik2708 <[email protected]> * add local-release to makefile Signed-off-by: Aryan-sharma11 <[email protected]> * remove contains element Signed-off-by: Aryan-sharma11 <[email protected]> * fix snyk failures and bump dependencies Signed-off-by: Aryan-sharma11 <[email protected]> --------- Signed-off-by: Manik2708 <[email protected]> Signed-off-by: Aryan-sharma11 <[email protected]> Co-authored-by: Aryan-sharma11 <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #270, #50
Karmor is now succesfully getting compiled on windows with removal of cilium completely from repository!