Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate vm package and upgrade dependencies #476

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Deprecate vm package and upgrade dependencies #476

merged 2 commits into from
Jan 17, 2025

Conversation

rksharma95
Copy link
Contributor

with this PR meged the deprecated package vm will be removed so the karmor vm command:

karmor vm --help
VM commands for kvmservice

Usage:
  karmor vm [command]

Available Commands:
  add         onboard new VM onto kvms control plane vm
  delete      offboard existing VM from kvms control plane vm
  getscript   download vm installation script for kvms control plane
  label       label handling for kvms control plane vm
  list        list configured VMs
  policy      policy handling for bare-metal vm/kvms control plane vm

daemon1024
daemon1024 requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check https://github.com/kubearmor/KubeArmor/blob/main/getting-started/kubearmor_vm.md#apply-sample-policy

Don't remove policy add/delete code

vm/policy.go Show resolved Hide resolved
@rksharma95 rksharma95 force-pushed the deprecate-vm-package branch 3 times, most recently from 4d5d56a to 90ab699 Compare January 16, 2025 12:10
daemon1024
daemon1024 requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, please remove mention of control plane keyword from description. KVM was a control plane now nothing is control plane it's just direct interaction with KubeArmor

README.md Outdated Show resolved Hide resolved
@rksharma95
remove deprecated package vm
9cbd026 
Signed-off-by: rksharma95 <[email protected]>
@rksharma95
upgrade go dependencies
c01547a 
Signed-off-by: rksharma95 <[email protected]>

upgrade go dependencies

Signed-off-by: rksharma95 <[email protected]>
@rksharma95 rksharma95 force-pushed the deprecate-vm-package branch from 90ab699 to c01547a Compare January 16, 2025 14:46
@rksharma95 rksharma95 merged commit 325762c into kubearmor:main Jan 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daemon1024 daemon1024 daemon1024 approved these changes

@Aryan-sharma11 Aryan-sharma11 Aryan-sharma11 approved these changes

@seswarrajan seswarrajan Awaiting requested review from seswarrajan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rksharma95 @daemon1024 @Aryan-sharma11