This repository has been archived by the owner on Jan 31, 2022. It is now read-only.
Create a new cluster for chatbot based on the GCP blueprint. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We want to create a webhook to respond to Dialogflow. To do that we need be able to modify the ISTIO ingress policy in order to apply different JWT validation for requests routed through IAP vs calls from DialogFlow. * I initially tried that using ISTIO 1.1 and ran into problems. On ISTIO 1.4 it seemed to work. * So this PR defines a new cluster based on the Kubeflow GCP blueprint so using ASM which has ISTIO 1.4. It is also using ACM to manage the deployment. * Related to kubeflow#142
|
This change is |
|
@hamelsmu mind taking a quick look at this? |
|
The following users are mentioned in OWNERS file(s) but are not members of the kubeflow org. Once all users have been added as members of the org, you can trigger verification by writing
|
jlewi
pushed a commit
to jlewi/testing
that referenced
this pull request
May 23, 2020
* For now, it looks like using multiple acm-repo (i.e. different
repos for different clusters) will work better than trying
to use a single acm-repo and cluster selectors.
* I was hitting problems with the fact that Tekton can't be installed
via ACM right now (it violates certain validation constraints).
* I only wanted to install tekton on the auto-deploy cluster (kf-ci-v1)
and not the kf-ci-management cluster but I was stil
getting errors from ACM complaining the Tekton configs were invalid.
* So as a work around I renamed acm-repo -> acm-repos with the intent
we will have multiple subdirectories corresponding to different repos
* A given cluster can then choose which cluster to enroll in
* Create a new cluster for the KF chatbot (see kubeflow/code-intelligence#142)
* The cluster will be managed using CNRM and ACM on the kf-ci-management
cluster. So we need to check in the configs.
* The source (kustomize packages for the manifests) is in
kubeflow/code-intelligence#145
|
/lgtm This PR changes an epic number of files |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hamelsmu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
pushed a commit
to kubeflow/testing
that referenced
this pull request
May 26, 2020
* For now, it looks like using multiple acm-repo (i.e. different
repos for different clusters) will work better than trying
to use a single acm-repo and cluster selectors.
* I was hitting problems with the fact that Tekton can't be installed
via ACM right now (it violates certain validation constraints).
* I only wanted to install tekton on the auto-deploy cluster (kf-ci-v1)
and not the kf-ci-management cluster but I was stil
getting errors from ACM complaining the Tekton configs were invalid.
* So as a work around I renamed acm-repo -> acm-repos with the intent
we will have multiple subdirectories corresponding to different repos
* A given cluster can then choose which cluster to enroll in
* Create a new cluster for the KF chatbot (see kubeflow/code-intelligence#142)
* The cluster will be managed using CNRM and ACM on the kf-ci-management
cluster. So we need to check in the configs.
* The source (kustomize packages for the manifests) is in
kubeflow/code-intelligence#145
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to create a webhook to respond to Dialogflow. To do
that we need be able to modify the ISTIO ingress policy in order
to apply different JWT validation for requests routed through IAP
vs calls from DialogFlow.
I initially tried that using ISTIO 1.1 and ran into problems. On ISTIO 1.4
it seemed to work.
So this PR defines a new cluster based on the Kubeflow GCP blueprint
so using ASM which has ISTIO 1.4. It is also using ACM to manage
the deployment.
Related to [chatbot] Start building a KF assistant - who owns this label? #142