Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Exclude build artifacts from package via gitignore #43

Closed
wants to merge 1 commit into from

Conversation

snekkalapudi
Copy link

@snekkalapudi snekkalapudi commented Feb 14, 2020

Github issue: #7
Adding build/ to .gitignore


This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from abhi-g and jlewi February 14, 2020 04:23
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign abhi-g
You can assign the PR to them by writing /assign @abhi-g in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@snekkalapudi
Copy link
Author

/assign @abhi-g

@jlewi
Copy link
Contributor

jlewi commented Feb 14, 2020

/assign @avdaredevil

@jlewi
Copy link
Contributor

jlewi commented Feb 14, 2020

/assign @kwasi

@jlewi jlewi removed the request for review from abhi-g February 14, 2020 06:26
@Bobgy
Copy link
Contributor

Bobgy commented Sep 1, 2020

Hi @snekkalapudi, it's not enough just excluding it, now build dir is required by this repo's consumers

Copy link
Contributor

@jlewi jlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR should be closed.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: snekkalapudi
To complete the pull request process, please ask for approval from avdaredevil after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avdaredevil
Copy link
Contributor

/close

@google-oss-robot
Copy link

@avdaredevil: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants