-
Notifications
You must be signed in to change notification settings - Fork 141
chroe(frontend): Better CSS on Compile and upload button #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
jesuino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @FAUST-BENCHOU
Thanks for your contribution!
The change looks great for the text alignment. I was also expecting the breadcumb button size to keep a fixed size when the button is resized. This is what I see when I resize the panel:
I was expecting to be of a fixed size (about 5%) and the floating menu to be on the right side as well, but I know that moving the menu is hard because it has absolute position.
now it can meet your needs @jesuino |
jesuino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@FAUST-BENCHOU can you resolve the conflicts? Then I will approve and merge |
Signed-off-by: zhoujinyu <2319109590@qq.com>
81ad66b to
ee412d3
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Done! |
|
@FAUST-BENCHOU can you fix the lint issues? |
|
@FAUST-BENCHOU, if you run make lint, you should be able to check everything that is breaking in the CI. |
|
Btw, the pre-commit hooks should caught this, I'll investigate it later in a follow-up. For now, could you please run make lint, test, and push your changes? |


Close #562 (comment)
Before:

After:
