-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix katib use crds token pipeline trail template guide #2330
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this update @Jerry-yz!
I noticed that we have appropriate steps to support Tekton pipeline with Katib Trial here: https://www.kubeflow.org/docs/components/katib/user-guides/trial-template/#use-crds-with-trial-template
Should we just link this guide to the Katib controller section in this doc?
i have update it, you can review it, thanks? |
Thank you for your contribution @Jerry-yz! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Jerry-yz Please rebase your PR to fix the CI/CD. |
Signed-off-by: Jerry-yz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
Signed-off-by: Jerry-yz <[email protected]>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: