Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-picked c18035e1 #2517

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

mahdikhashan
Copy link
Member

What this PR does / why we need it:
cherry-pick of #2466

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes -

Checklist:

  • Docs included if any changes are user facing

* Support old-style TensorFlow events (tensorboard)

Fixes: kubeflow#2466
Signed-off-by: Gary Miguel <[email protected]>

* format

Signed-off-by: Gary Miguel <[email protected]>

* test

Signed-off-by: Gary Miguel <[email protected]>

* don't continue loops

Signed-off-by: Gary Miguel <[email protected]>

* format

Signed-off-by: Gary Miguel <[email protected]>

---------

Signed-off-by: Gary Miguel <[email protected]>
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mahdikhashan!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7dcdde7 into kubeflow:release-0.18 Feb 17, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants