-
Notifications
You must be signed in to change notification settings - Fork 123
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(sdk): fix nested loop global param bug (#917)
* fix nested loop global param bug * fix nested loop global param bug * add license * fix recursion bug
- Loading branch information
Showing
9 changed files
with
496 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
sdk/python/tests/compiler/testdata/nested_loop_global_param.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| # Copyright 2022 kubeflow.org | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from kfp import dsl | ||
| from kfp.components import load_component_from_text | ||
| from kfp_tekton.compiler import TektonCompiler | ||
|
|
||
|
|
||
| class Coder: | ||
| def empty(self): | ||
| return "" | ||
|
|
||
|
|
||
| TektonCompiler._get_unique_id_code = Coder.empty | ||
|
|
||
|
|
||
| def PrintOp(name: str, msg: str = None): | ||
| if msg is None: | ||
| msg = name | ||
| print_op = load_component_from_text( | ||
| """ | ||
| name: %s | ||
| inputs: | ||
| - {name: input_text, type: String, description: 'Represents an input parameter.'} | ||
| outputs: | ||
| - {name: output_value, type: String, description: 'Represents an output paramter.'} | ||
| implementation: | ||
| container: | ||
| image: alpine:3.6 | ||
| command: | ||
| - sh | ||
| - -c | ||
| - | | ||
| set -e | ||
| echo $0 > $1 | ||
| - {inputValue: input_text} | ||
| - {outputPath: output_value} | ||
| """ % (name) | ||
| ) | ||
| return print_op(msg) | ||
|
|
||
|
|
||
| @dsl.pipeline("empty-loop") | ||
| def nested_loop(param: list = ["a", "b", "c"]): | ||
| # param of the inner loop is used inner-most --- works fine | ||
| with dsl.ParallelFor(param): | ||
| with dsl.ParallelFor(param): | ||
| PrintOp('print-0', f"print {param}") | ||
|
|
||
| # param of the inner loop is not used inner-most --- fails | ||
| with dsl.ParallelFor(param): | ||
| with dsl.ParallelFor(param): | ||
| PrintOp('print-1', "print") | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| TektonCompiler().compile(nested_loop, __file__.replace('.py', '.yaml')) |
Oops, something went wrong.