Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seaweedfs to contrib #2826

Merged

Conversation

pschoen-itsc
Copy link
Contributor

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I added seaweedfs to contrib which could be a replacement for minio

📦 List any dependencies that are required for this change

🐛 If this PR is related to an issue, please put the link to the issue here.

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@juliusvonkohout
Copy link
Member

/ok-to-test

@juliusvonkohout
Copy link
Member

And first of all thank you very much for the PR.

@juliusvonkohout juliusvonkohout self-assigned this Aug 1, 2024
@juliusvonkohout
Copy link
Member

This is a follow up of the discussion in kubeflow/pipelines#10998

@pschoen-itsc
Copy link
Contributor Author

pschoen-itsc commented Sep 2, 2024

One current problem is getting an artifact via the Artifacts view in the UI. mlpipeline-ui crashes because of a missing region parameter in the js minio client. Not sure why this problem appears when using seaweedfs, because there is no change in configuration there.

@pschoen-itsc pschoen-itsc force-pushed the add-seaweedfs-to-contrib branch 2 times, most recently from 0ac99d3 to f4eb716 Compare September 3, 2024 16:40
@google-oss-prow google-oss-prow bot added size/XXL and removed size/L labels Sep 3, 2024
@pschoen-itsc pschoen-itsc force-pushed the add-seaweedfs-to-contrib branch from f4eb716 to 3b15e90 Compare September 3, 2024 16:44
@google-oss-prow google-oss-prow bot added size/L and removed size/XXL labels Sep 3, 2024
@juliusvonkohout
Copy link
Member

/ok-to-test

Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
@pschoen-itsc pschoen-itsc force-pushed the add-seaweedfs-to-contrib branch from 1565802 to b09fc19 Compare September 4, 2024 13:00
@pschoen-itsc
Copy link
Contributor Author

Pipeline should succeed now.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Sep 27, 2024

@pschoen-itsc shall I review this for merging or do you want to continue with the user management in the same PR? Please also check kubeflow/pipelines#10998 (comment).

@pschoen-itsc
Copy link
Contributor Author

@pschoen-itsc shall I review this for merging or do you want to continue with the user management in the same PR? Please also check kubeflow/pipelines#10998 (comment).

You can review this. I think it is better to do the user management in a different PR.

Signed-off-by: Patrick Schönthaler <[email protected]>
@pschoen-itsc pschoen-itsc force-pushed the add-seaweedfs-to-contrib branch from eaabbc5 to 254b6f4 Compare September 30, 2024 07:35
@juliusvonkohout
Copy link
Member

Somehow https://github.com/kubeflow/manifests/actions/runs/11101539942/job/30958766562 failed. If it fails on the rerun again we have to fix this first before merging.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Oct 2, 2024

Maybe a rebase to master is helpful as well, because some tests and scripts changed with the latest commit yesterday.

@juliusvonkohout
Copy link
Member

Yes, a rebase is necessary.

@pschoen-itsc
Copy link
Contributor Author

pschoen-itsc commented Oct 2, 2024

Yes, a rebase is necessary.

Will do it today.

Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
@juliusvonkohout juliusvonkohout self-requested a review October 2, 2024 14:00
@juliusvonkohout
Copy link
Member

/lgtm
/approve

Thank you very much. For the user management we will also need some tests to make sure that they cannot access other users artifacts. We also need to verify that the artifacts work in the UI.

@google-oss-prow google-oss-prow bot added the lgtm label Oct 2, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit aee7929 into kubeflow:master Oct 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants