feat(deployment): keep defaulting to argo docker container runtime ex…

…ecutor. Part of #5285 (#5312)

manifests/kustomize/env/platform-agnostic-pns/kustomization.yaml

@@ -1,5 +1,7 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 bases:
-# platform-agnostic env is already defaulting to pns, so this env will be removed soon.
 - ../platform-agnostic
+
+patchesStrategicMerge:
+- workflow-controller-configmap-patch.yaml

manifests/kustomize/env/platform-agnostic-pns/workflow-controller-configmap-patch.yaml

@@ -0,0 +1,14 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: workflow-controller-configmap
+data:
+  # References:
+  # * https://github.com/argoproj/argo-workflows/blob/v2.12.9/config/config.go
+  # * https://github.com/argoproj/argo-workflows/blob/v2.12.9/docs/workflow-controller-configmap.md
+  # * https://github.com/argoproj/argo-workflows/blob/v2.12.9/docs/workflow-controller-configmap.yaml
+
+  # pns executor is a more portable default, see https://github.com/kubeflow/pipelines/issues/1654.
+  # However, it is flaky for containers that run really fast, see https://github.com/kubeflow/pipelines/issues/5285.
+  # So we still default to docker for now.
+  containerRuntimeExecutor: pns

manifests/kustomize/third-party/argo/base/workflow-controller-configmap-patch.yaml

@@ -9,7 +9,9 @@ data:
   # * https://github.com/argoproj/argo-workflows/blob/v2.12.9/docs/workflow-controller-configmap.yaml
 
   # pns executor is a more portable default, see https://github.com/kubeflow/pipelines/issues/1654.
-  containerRuntimeExecutor: pns
+  # However, it is flaky for containers that run really fast, see https://github.com/kubeflow/pipelines/issues/5285.
+  # So we still default to docker for now.
+  containerRuntimeExecutor: docker
 
   # In artifactRepository.s3.endpoint, $(kfp-namespace) is needed, because in multi-user mode, pipelines may run in other namespaces.
   artifactRepository: |