fix(config-syncer): b64enc $serverKey
and $serverCrt
#133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I believe in most cases people provide certificates by
--set-file
.The files(e.g.
config-syncer.crt
,config-syncer.key
) are raw certificates(not pre-encoded) in general.So the chart should
b64enc
by itself.Whether to consider this a breaking change or a major feature or a minor patch is up to you,
though I think it's not actually a breaking change but a patch, because this behavior is highly expected conventionally.
Thanks :)