Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-syncer): b64enc $serverKey and $serverCrt #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjangga0214
Copy link

@jjangga0214 jjangga0214 commented Nov 14, 2023

Hi!

I believe in most cases people provide certificates by --set-file.

helm install config-syncer \
  --set-file apiserver.servingCerts.serverCrt=config-syncer.crt \
  --set-file apiserver.servingCerts.serverKey=config-syncer.key \
  ./config-syncer

The files(e.g. config-syncer.crt, config-syncer.key) are raw certificates(not pre-encoded) in general.
So the chart should b64enc by itself.

Whether to consider this a breaking change or a major feature or a minor patch is up to you,
though I think it's not actually a breaking change but a patch, because this behavior is highly expected conventionally.

Thanks :)

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants