Skip to content

Revert the change from json-patch to merge-patch #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

brendandburns
Copy link
Contributor

Fixes #476 for now.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2020
@tg123
Copy link
Member

tg123 commented Oct 27, 2020

so fixed by s/json-path/merge-path/g ?
this is due to autorest?

maybe by adding it to gen

@brendandburns
Copy link
Contributor Author

brendandburns commented Oct 28, 2020

@tg123 I'm thinking about adding it to the gen repo, but I'm trying to sort out a better answer w/ the autorest folks, this is a temporary patch until I figure out what we're doing.

(and yes perl -pi -e s/json-patch/merge-patch/g Kubernetes.cs is how I made this change)

@tg123
Copy link
Member

tg123 commented Oct 28, 2020

/LGTM

btw, there was sed in https://github.com/kubernetes-client/gen/blob/master/openapi/csharp.sh#L62 already

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3772ffb into kubernetes-client:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PatchNamespacedCustomObjectWithHttpMessagesAsync fails with the latest nuget 2.0.29.
3 participants