Delete from yaml #1197

DiptoChakrabarty · 2020-07-07T19:43:15Z

This is a method to delete kubernetes resources using the yaml files . It is similar to the method create_from_yaml but for deleting kubernetes resources .
It can be used to any type pf resource deployment , pod , service etc.
Fixes #940

Resolved issue for tests failing for python2.7

create_from_yaml creates kubernetes objects like deployments,serivces,ingress etc from the given yml files , the delete_from_yaml method can be used to remove/delete those objects from the same yml files in the given cluster for any namespace

k8s-ci-robot · 2020-07-07T19:43:19Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-07-07T19:43:23Z

Welcome @DiptoChakrabarty!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

moshevayner · 2020-07-08T00:10:09Z

Hey @DiptoChakrabarty
Thanks for your PR!
Looks like you need to sign the CLA, can you please follow these instructions and sign?

DiptoChakrabarty · 2020-07-08T05:25:32Z

Hey @DiptoChakrabarty
Thanks for your PR!
Looks like you need to sign the CLA, can you please follow these instructions and sign?

Yes I have done it

DiptoChakrabarty · 2020-07-13T03:17:08Z

HI @roycaihw , @yliaog can you please review this PR

yliaog · 2020-07-13T04:05:16Z

kubernetes/utils/delete_from_yaml.py

+        print(msg)
+
+
+class FailToCreateError(Exception):


should it be FailToDeleteError?

yliaog · 2020-07-13T04:06:09Z

kubernetes/utils/delete_from_yaml.py

+    # convert group name from DNS subdomain format to
+    # python class name convention
+    group = "".join(word.capitalize() for word in group.split('.'))
+    group = "".join(word.capitalize() for word in group.split('.'))


looks the two lines above are the same?

Yes resolving these small issues

yliaog · 2020-07-13T04:07:51Z

kubernetes/utils/delete_from_yaml.py

+from kubernetes import client
+
+
+def delete_from_yaml(


overall, what is the difference between this and create_from_yaml? could you please list the differences in the PR description? is it possible to reuse to avoid dups?

Yes I will do it

I have written the difference between the methods create_from_yaml and delete_from_yaml editing the PR description and also fixed the issues as stated earlier.

roycaihw

please add some e2e testcases in https://github.com/kubernetes-client/python/blob/master/kubernetes/e2e_test/test_utils.py and update https://github.com/kubernetes-client/python/blob/master/kubernetes/utils/__init__.py

roycaihw · 2020-07-30T01:14:35Z

kubernetes/utils/delete_from_yaml.py

@@ -0,0 +1,146 @@
+import re


please add copyright boilerplate

sure Ill add the boilerplate and try writing the tests

added the boilerplate and added tests also modifying delete_from_dict function

roycaihw · 2020-07-30T01:18:07Z

kubernetes/utils/delete_from_yaml.py

+            this parameter has no effect.
+        Available parameters for creating <kind>:
+        :param async_req bool
+        :param bool include_uninitialized: If true, partially initialized


the initializer feature has been removed

roycaihw · 2020-07-30T01:21:44Z

kubernetes/utils/delete_from_yaml.py

+    API object (i.e. List, Service, etc).
+    Input:
+    k8s_client: an ApiClient object, initialized with the client args.
+    data: a dictionary holding valid kubernetes objects


the comment doesn't match the parameter

changed the comment with correct parameter

roycaihw · 2020-07-30T01:34:15Z

kubernetes/utils/delete_from_yaml.py

+        name = yml_document["metadata"]["name"]
+        #call function to delete from namespace
+        res = getattr(k8s_api,"delete_namespaced_{}".format(kind))(
+         name=name,body=client.V1DeleteOptions(propagation_policy="Foreground", grace_period_seconds=5),**kwargs)


if we want to achieve parity with kubectl delete -f, we should probably use Background policy by default with a Cascade option: https://github.com/kubernetes/kubernetes/blob/0c642b6ef01071219b9b9e34ad6d89cb9b4b1971/staging/src/k8s.io/kubectl/pkg/cmd/delete/delete.go#L304-L308

have updated this to use background policy

roycaihw · 2020-07-30T01:45:38Z

kubernetes/utils/delete_from_yaml.py

+        name = yml_document["metadata"]["name"]
+        kwargs.pop('namespace', None)
+        res = getattr(k8s_api,"delete_{}".format(kind))(
+         name=name,body=client.V1DeleteOptions(propagation_policy="Foreground", grace_period_seconds=5),**kwargs)


A 200 response from a delete request doesn't guarantee the resource being deleted. We should wait until the resource is no longer visible from the server.

How should the e2e tests work for objects being deleted , after deletion if they are search (the object) it gets timed out resulting in an error ,however in the create_from_yaml tests in the end all resources are being deleted using multiple separate commands could we delete those using the delete_from_yaml method and that would be sufficient?

/assign @yliaog

in e2e, after delete, try listing the object again, if it does not exist anymore, it means the object is successfully deleted.

psikka1 · 2020-08-04T01:23:24Z

@DiptoChakrabarty @roycaihw - Does the API support non-namespaced resources such as ClusterRole? I am failing to delete the cluster role with this error -

line 115, in delete_from_yaml_single_item
    if getattr(k8s_api, "delete_namespaced_{}".format(kind)):
AttributeError: 'RbacAuthorizationV1Api' object has no attribute 'delete_namespaced_cluster_role'

I feel they should also be supported. Same seems to be the case with create_from_yaml.
Another likely bug I noticed was that when the yaml doc has a blank item, this fails.

...
---

---
...
...

Adding a check
if yml_document:
before this line would do the job.

palnabarun · 2020-11-23T04:50:08Z

/hold

(for resolving the issues with the commit history in this branch)

DiptoChakrabarty · 2020-11-23T08:09:27Z

hey can you tell me how can I resolve this commit history issue .
About the pycodestyle test I ran the bash script locally as suggested and this was the error kubernetes/utils/quantity.py:24:80: E501 line too long (91 > 79 characters)
which is this commented line 'See https://github.com/kubernetes/apimachinery/blob/master/pkg/api/resource/quantity.go'
I did not do any changes in that file hence

liavyona · 2021-01-27T16:37:15Z

Can you please merge?

DiptoChakrabarty · 2021-02-03T17:40:19Z

Hey can I send a new PR again with the same content , then can close this PR

roycaihw · 2021-03-01T19:38:18Z

@DiptoChakrabarty Could you open a new PR? That would help with rebasing and squashing the commits. Thanks!

k8s-ci-robot · 2021-03-18T18:38:42Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DiptoChakrabarty
To complete the pull request process, please ask for approval from yliaog after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

palnabarun · 2021-06-06T06:32:42Z

Looks like this is superseded by #1392.

Closing this. Please reopen if it's not the case.

palnabarun · 2021-06-06T06:32:48Z

/close

k8s-ci-robot · 2021-06-06T06:32:50Z

@palnabarun: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

DiptoChakrabarty added 2 commits July 7, 2020 19:53

created method to delete from yaml files

b61fb5c

function when namespaced delete not found

5fc0f53

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 7, 2020

k8s-ci-robot requested review from roycaihw and yliaog July 7, 2020 19:43

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 7, 2020

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 8, 2020

DiptoChakrabarty added 2 commits July 12, 2020 10:17

change syntax for delete operation

d339958

resolve kwargs error for python2.7

a8e5ac3

yliaog reviewed Jul 13, 2020

View reviewed changes

fixed typo errors

7e75c96

roycaihw reviewed Jul 30, 2020

View reviewed changes

DiptoChakrabarty added 7 commits August 24, 2020 10:08

created method to delete from yaml files

9605ff1

function when namespaced delete not found

f153cf1

change syntax for delete operation

829ecc8

resolve kwargs error for python2.7

c86181b

fixed typo errors

1e3093b

e2e tests of resource deletion

424fb43

e2e tests of resource deletion

0108418

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 24, 2020

DiptoChakrabarty added 2 commits August 24, 2020 16:38

add e2e tests for multi resources and add method to delete of kind list

4e3d675

changed propagation policy to background and updated comment

b010a19

DiptoChakrabarty added 13 commits November 16, 2020 16:14

resolve kwargs error for python2.7

b03e37e

fixed typo errors

81374a3

e2e tests of resource deletion

4e81da5

add e2e tests for multi resources and add method to delete of kind list

0bf74fc

changed propagation policy to background and updated comment

36838fc

time limit exceeded case

371d252

tests to verify resource deletion

c87c272

error in multi resource test fix

3ce0c5a

fix namespace deletion error and being deleted case

e87ad34

minor change

95b1d2c

fix code style errors

2e22a7b

namespace condition error fix

fa84691

merge conflict fix

de8d44e

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2020

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2020

roycaihw mentioned this pull request Mar 1, 2021

Add a support to delete kubernetes API objects from yaml #1373

Closed

tox test

2bfdf96

tox line break check

b0c1eab

k8s-ci-robot closed this Jun 6, 2021

dyens mentioned this pull request Feb 6, 2023

Add a support to delete kubernetes API objects from yaml tomplus/kubernetes_asyncio#238

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete from yaml #1197

Delete from yaml #1197

DiptoChakrabarty commented Jul 7, 2020 •

edited

Loading

k8s-ci-robot commented Jul 7, 2020

k8s-ci-robot commented Jul 7, 2020

moshevayner commented Jul 8, 2020

DiptoChakrabarty commented Jul 8, 2020

DiptoChakrabarty commented Jul 13, 2020

yliaog Jul 13, 2020

yliaog Jul 13, 2020

DiptoChakrabarty Jul 13, 2020

yliaog Jul 13, 2020

DiptoChakrabarty Jul 13, 2020

DiptoChakrabarty Jul 28, 2020

roycaihw left a comment

roycaihw Jul 30, 2020

DiptoChakrabarty Aug 17, 2020

DiptoChakrabarty Aug 24, 2020

roycaihw Jul 30, 2020

roycaihw Jul 30, 2020

DiptoChakrabarty Aug 31, 2020

roycaihw Jul 30, 2020

DiptoChakrabarty Aug 31, 2020

roycaihw Jul 30, 2020

DiptoChakrabarty Sep 4, 2020

DiptoChakrabarty Sep 7, 2020

yliaog Sep 7, 2020

psikka1 commented Aug 4, 2020 •

edited

Loading

palnabarun commented Nov 23, 2020

DiptoChakrabarty commented Nov 23, 2020

liavyona commented Jan 27, 2021

DiptoChakrabarty commented Feb 3, 2021

roycaihw commented Mar 1, 2021

k8s-ci-robot commented Mar 18, 2021

palnabarun commented Jun 6, 2021

palnabarun commented Jun 6, 2021

k8s-ci-robot commented Jun 6, 2021

Delete from yaml #1197

Delete from yaml #1197

Conversation

DiptoChakrabarty commented Jul 7, 2020 • edited Loading

k8s-ci-robot commented Jul 7, 2020

k8s-ci-robot commented Jul 7, 2020

moshevayner commented Jul 8, 2020

DiptoChakrabarty commented Jul 8, 2020

DiptoChakrabarty commented Jul 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

roycaihw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

psikka1 commented Aug 4, 2020 • edited Loading

palnabarun commented Nov 23, 2020

DiptoChakrabarty commented Nov 23, 2020

liavyona commented Jan 27, 2021

DiptoChakrabarty commented Feb 3, 2021

roycaihw commented Mar 1, 2021

k8s-ci-robot commented Mar 18, 2021

palnabarun commented Jun 6, 2021

palnabarun commented Jun 6, 2021

k8s-ci-robot commented Jun 6, 2021

DiptoChakrabarty commented Jul 7, 2020 •

edited

Loading

psikka1 commented Aug 4, 2020 •

edited

Loading