Add --enable-list-snapshots command-line option #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This commit introduces the --enable-list-snapshots command-line option, allowing users to explicitly enable or disable the ControllerServiceCapability_RPC_LIST_SNAPSHOTS capability. By default, this option is set to true to preserve existing behavior. Disabling RPC_LIST_SNAPSHOTS is useful for emulating the behavior of CSI drivers that do not support this optional RPC call. Signed-off-by: Leonardo Cecchi <[email protected]>
leonardoce
force-pushed
the
dev/enable-disable-list-snapshots
branch
from
91e1d9d to
616de96
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leonardoce The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This commit introduces the --enable-list-snapshots command-line option, allowing users to explicitly enable or disable the ControllerServiceCapability_RPC_LIST_SNAPSHOTS capability.
By default, this option is set to true to preserve existing behavior.
Disabling RPC_LIST_SNAPSHOTS is useful for emulating the behavior of CSI drivers that do not support this optional RPC call.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: