Skip to content

Add details about secrets for ControllerModifyVolume#631

Open
nixpanic wants to merge 1 commit intokubernetes-csi:masterfrom
nixpanic:VolumeAttributeClass/secrets
Open

Add details about secrets for ControllerModifyVolume#631
nixpanic wants to merge 1 commit intokubernetes-csi:masterfrom
nixpanic:VolumeAttributeClass/secrets

Conversation

@nixpanic
Copy link
Member

@nixpanic nixpanic commented Nov 14, 2025 •
edited
Loading

The secret references for ControllerModifyVolume have been added to the documentation of the StorageClass. There is also an explanation that the external-provisioner adds annotations on the PV so that the external-resizer can use them.

Depends on released sidecars:

  • external-provisioner v6.2.0
  • external-resizer v2.1.0

See-also: kubernetes-csi/external-resizer#544 kubernetes-csi/external-provisioner#1440

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 14, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nixpanic
Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2025
@nixpanic nixpanic marked this pull request as ready for review December 10, 2025 09:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2025
@k8s-ci-robot k8s-ci-robot requested a review from lpabon December 10, 2025 09:12
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 10, 2025
This was referenced Jan 21, 2026
Merged
Open
Merged
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Jan 22, 2026
@nixpanic
doc: add details about VolumeAttributeClass secrets
fbcf2c7 
Only Kubernetes 1.34 and newer support VolumeAttributeClass
functionality (GA). Ceph-CSI also depends on certain versions of the
Kubernetes CSI external-provisioner and external-resizer.

See-also: kubernetes-csi/docs#631
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Jan 22, 2026
@nixpanic
doc: add details about VolumeAttributeClass secrets
76db8f7 
Only Kubernetes 1.34 and newer support VolumeAttributeClass
functionality (GA). Ceph-CSI also depends on certain versions of the
Kubernetes CSI external-provisioner and external-resizer.

See-also: kubernetes-csi/docs#631
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Jan 23, 2026
@nixpanic
doc: add details about VolumeAttributeClass secrets
46d8735 
Only Kubernetes 1.34 and newer support VolumeAttributeClass
functionality (GA). Ceph-CSI also depends on certain versions of the
Kubernetes CSI external-provisioner and external-resizer.

See-also: kubernetes-csi/docs#631
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Jan 23, 2026
@nixpanic
doc: add details about VolumeAttributeClass secrets
b0ffd1d 
Only Kubernetes 1.34 and newer support VolumeAttributeClass
functionality (GA). Ceph-CSI also depends on certain versions of the
Kubernetes CSI external-provisioner and external-resizer.

See-also: kubernetes-csi/docs#631
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Jan 23, 2026
@nixpanic
doc: add details about VolumeAttributeClass secrets
ea99e05 
Only Kubernetes 1.34 and newer support VolumeAttributeClass
functionality (GA). Ceph-CSI also depends on certain versions of the
Kubernetes CSI external-provisioner and external-resizer.

See-also: kubernetes-csi/docs#631
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Feb 3, 2026
@nixpanic
doc: add details about VolumeAttributeClass secrets
29196c5 
Only Kubernetes 1.34 and newer support VolumeAttributeClass
functionality (GA). Ceph-CSI also depends on certain versions of the
Kubernetes CSI external-provisioner and external-resizer.

See-also: kubernetes-csi/docs#631
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Feb 4, 2026
@nixpanic
doc: add details about VolumeAttributeClass secrets
cd729f3 
Only Kubernetes 1.34 and newer support VolumeAttributeClass
functionality (GA). Ceph-CSI also depends on certain versions of the
Kubernetes CSI external-provisioner and external-resizer.

See-also: kubernetes-csi/docs#631
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Feb 4, 2026
@nixpanic
doc: add details about VolumeAttributeClass secrets
a38a8cc 
Only Kubernetes 1.34 and newer support VolumeAttributeClass
functionality (GA). Ceph-CSI also depends on certain versions of the
Kubernetes CSI external-provisioner and external-resizer.

See-also: kubernetes-csi/docs#631
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Feb 4, 2026
@nixpanic
doc: add details about VolumeAttributeClass secrets
a21f29a 
Only Kubernetes 1.34 and newer support VolumeAttributeClass
functionality (GA). Ceph-CSI also depends on certain versions of the
Kubernetes CSI external-provisioner and external-resizer.

See-also: kubernetes-csi/docs#631
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Feb 5, 2026
@nixpanic
doc: add details about VolumeAttributeClass secrets
d38f660 
Only Kubernetes 1.34 and newer support VolumeAttributeClass
functionality (GA). Ceph-CSI also depends on certain versions of the
Kubernetes CSI external-provisioner and external-resizer.

See-also: kubernetes-csi/docs#631
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Feb 5, 2026
@nixpanic
doc: add details about VolumeAttributeClass secrets
b4565bd 
Only Kubernetes 1.34 and newer support VolumeAttributeClass
functionality (GA). Ceph-CSI also depends on certain versions of the
Kubernetes CSI external-provisioner and external-resizer.

See-also: kubernetes-csi/docs#631
Signed-off-by: Niels de Vos <ndevos@ibm.com>
mergify bot pushed a commit to ceph/ceph-csi that referenced this pull request Feb 6, 2026
@nixpanic @mergify
doc: add details about VolumeAttributeClass secrets
94c5e36 
Only Kubernetes 1.34 and newer support VolumeAttributeClass
functionality (GA). Ceph-CSI also depends on certain versions of the
Kubernetes CSI external-provisioner and external-resizer.

See-also: kubernetes-csi/docs#631
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
Add details about secrets for ControllerModifyVolume
b055a61 
The secret references for ControllerModifyVolume have been added to the
documentation of the StorageClass. There is also an explanation that the
external-provisioner adds annotations on the PV so that the
external-resizer can use them.
@nixpanic nixpanic force-pushed the VolumeAttributeClass/secrets branch from 4235d93 to b055a61 Compare March 2, 2026 11:09
@nixpanic
Copy link
Member Author

nixpanic commented Mar 2, 2026

@xing-yang @jsafrane , with the external-provisioner v6.2.0 that has been tagged today, this is now ready for review/merging too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

@lpabon lpabon Awaiting requested review from lpabon

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nixpanic @k8s-ci-robot