Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting String Interpolation for Modifying Tags On Existing Volumes Through VAC #2093

Merged
merged 11 commits into from
Feb 11, 2025
Merged

Supporting String Interpolation for Modifying Tags On Existing Volumes Through VAC #2093

merged 11 commits into from
Feb 11, 2025

Conversation

mdzraf
Copy link
Contributor

@mdzraf mdzraf commented Jul 22, 2024

Is this a bug fix or adding new feature?

New feature

What is this PR about? / Why do we need it?

This will add the support for runtime string interpolation on tag values for a volume upon modification, which allows for customers to specify placeholder values for the PVC namespace, PVC name and PV name, which will then be dynamically computed at runtime.

What testing is done?

Unit tests were ran to ensure that input was parsed properly and manual testing was done after initial changes to external-resizer sidecar code were made to pass in the extra metadata necessary to the driver and ensuring that these tags were properly added at runtime.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 22, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 22, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mdzraf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2024
@ConnorJC3
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

Code Coverage Diff

File Old Coverage New Coverage Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/controller_modify_volume.go 78.3% 79.8% 1.5

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2024
@mdzraf mdzraf marked this pull request as ready for review July 31, 2024 18:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2024
@mdzraf
Copy link
Contributor Author

mdzraf commented Jul 31, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2024
@mdzraf
Copy link
Contributor Author

mdzraf commented Aug 1, 2024

/retest

1 similar comment
@mdzraf
Copy link
Contributor Author

mdzraf commented Aug 7, 2024

/retest

ConnorJC3
ConnorJC3 reviewed Aug 8, 2024
View reviewed changes
examples/kubernetes/modify-volume/manifests/volumeattributesclass.yaml Outdated Show resolved Hide resolved
pkg/driver/controller_modify_volume.go Outdated Show resolved Hide resolved
pkg/driver/controller_modify_volume.go Outdated Show resolved Hide resolved
pkg/driver/controller_modify_volume_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2024
@AndrewSirenko
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2024
@AndrewSirenko AndrewSirenko mentioned this pull request Nov 11, 2024
Open
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2025
@mdzraf
Copy link
Contributor Author

mdzraf commented Feb 7, 2025

/retest

ElijahQuinones
ElijahQuinones reviewed Feb 7, 2025
View reviewed changes
charts/aws-ebs-csi-driver/values.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/base/controller.yaml Outdated Show resolved Hide resolved
@ElijahQuinones
Copy link
Member

ElijahQuinones commented Feb 7, 2025 •
edited
Loading

Needs squash but
/lgtm
Thank you !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2025
@ElijahQuinones
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 7, 2025
@ElijahQuinones
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2025
mdzraf
mdzraf commented Feb 10, 2025
View reviewed changes
docs/tagging.md Outdated Show resolved Hide resolved
@torredil
Copy link
Member

/label tide/merge-method-squash
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
ElijahQuinones
ElijahQuinones approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@ElijahQuinones ElijahQuinones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thank you

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8814261 into kubernetes-sigs:master Feb 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 ConnorJC3 left review comments

@torredil torredil torredil approved these changes

@AndrewSirenko AndrewSirenko AndrewSirenko approved these changes

@ElijahQuinones ElijahQuinones ElijahQuinones approved these changes

Assignees

@AndrewSirenko AndrewSirenko

@torredil torredil

@ElijahQuinones ElijahQuinones

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mdzraf @k8s-ci-robot @ConnorJC3 @AndrewSirenko @ElijahQuinones @torredil