Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Helm values for IRSA #2324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cnemo-cenic
Copy link

@cnemo-cenic cnemo-cenic commented Jan 30, 2025

What type of PR is this?

/kind documentation

What is this PR about? / Why do we need it?

Both the controller and node service accounts need to have the referenced annotation set. Adding explicit placeholders rather than mock account ID which could more easily be copy-pasted unwittingly.

How was this change tested?

N/A - docs

Does this PR introduce a user-facing change?

N/A - docs

Both the controller and node service accounts need to have the referenced annotation set.
Adding explicit placeholders rather than mock account ID which could more easily be copy-pasted unwittingly.
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 30, 2025
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rdpsin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from torredil January 30, 2025 19:59
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @cnemo-cenic!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @cnemo-cenic. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2025
@cnemo-cenic
Copy link
Author

Hopefully a trivial docs-only change does not require CLA signing, as that may be a blocker here.

FWIW, the yaml snippet was lifted verbatim from the values.yaml in this repo.

Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnemo-cenic, thanks for your contribution! Unfortunately even documentation PRs need the contributor to sign CLA.

Would you want us to open an identical PR on your behalf instead? Let us know!

Comment on lines +99 to +102
node:
serviceAccount:
annotations:
eks.amazonaws.com/role-arn: arn:<partition>:iam::<account>:role/ebs-csi-role
Copy link
Contributor

@AndrewSirenko AndrewSirenko Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node SA does not need the role-arn annoation.

This is because our node DaemonSet pods use that ebs-csi IAM Role because no AWS EC2 API calls are made from ebs-csi-node pods.

Therefore lets delete this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants