-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update Helm values for IRSA #2324
base: master
Are you sure you want to change the base?
Conversation
Both the controller and node service accounts need to have the referenced annotation set. Adding explicit placeholders rather than mock account ID which could more easily be copy-pasted unwittingly.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @cnemo-cenic! |
Hi @cnemo-cenic. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hopefully a trivial docs-only change does not require CLA signing, as that may be a blocker here. FWIW, the yaml snippet was lifted verbatim from the values.yaml in this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cnemo-cenic, thanks for your contribution! Unfortunately even documentation PRs need the contributor to sign CLA.
Would you want us to open an identical PR on your behalf instead? Let us know!
node: | ||
serviceAccount: | ||
annotations: | ||
eks.amazonaws.com/role-arn: arn:<partition>:iam::<account>:role/ebs-csi-role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The node SA does not need the role-arn annoation.
This is because our node DaemonSet pods use that ebs-csi IAM Role because no AWS EC2 API calls are made from ebs-csi-node pods.
Therefore lets delete this part.
What type of PR is this?
/kind documentation
What is this PR about? / Why do we need it?
Both the controller and node service accounts need to have the referenced annotation set. Adding explicit placeholders rather than mock account ID which could more easily be copy-pasted unwittingly.
How was this change tested?
N/A - docs
Does this PR introduce a user-facing change?
N/A - docs